Give the share preview section explicit token states

Render the "Share preview link with someone else" section in two states:
when a token exists, show the copy link with options to regenerate or
delete it; when no token exists, show only a button to generate one.
Deleting a token flips the summary page to the empty state.

Author: TonyGDS

app/components/admin/editions/show/preview_component.html.erb

@@ -29,29 +29,46 @@
     <% end %>
 
     <% if local_edition.has_enabled_shareable_preview? %>
-      <% shareable_preview_link = show_url_with_auth_bypass_options(local_edition, draft: true, locale: local_edition.primary_locale) %>
-
       <%= render "govuk_publishing_components/components/details", {
-        title: "Share document preview",
+        title: "Share preview link with someone else",
       } do %>
-        <p class="govuk-body">Send this preview link to someone so they can see the content and how the document will appear on GOV.UK.</p>
-        <p class="govuk-body">No password is needed and anyone with the preview link can view it. You're responsible for who you share draft documents with. </p>
-        <p class="govuk-body">The preview link will expire on <%= Time.zone.today.next_month.strftime("%-d %B %Y") %> or when the document is published.</p>
-
-        <%= render "govuk_publishing_components/components/copy_to_clipboard", {
-          label: "Copy and send this link to someone and they’ll be able to preview your draft on GOV.UK.",
-          copyable_content: shareable_preview_link,
-          button_text: "Copy link",
-        } %>
-
-        <p class="govuk-body govuk-!-margin-top-7">Reset and generate a new preview link if you've shared the preview with the wrong person or if the link has expired. This will disable the previous preview link.</p>
-
-        <%= form_with(url: update_bypass_id_admin_edition_path(local_edition), method: :patch) do |f| %>
-          <input type="hidden" name="_method" value="patch">
-          <%= render "govuk_publishing_components/components/button", {
-            text: "Generate new link",
-            secondary_quiet: true,
+        <p class="govuk-body">Anyone with a link can preview the content on GOV.UK. No password is needed. You’re responsible for who you share the link with.</p>
+
+        <% if token_generated? %>
+          <% shareable_preview_link = show_url_with_auth_bypass_options(local_edition, draft: true, locale: local_edition.primary_locale) %>
+
+          <p class="govuk-body">The link will expire on <%= Time.zone.today.next_month.strftime("%-d %B %Y") %> or when the document is published.</p>
+
+          <%= render "govuk_publishing_components/components/copy_to_clipboard", {
+            label: "Preview link",
+            copyable_content: shareable_preview_link,
+            button_text: "Copy link",
           } %>
+
+          <p class="govuk-body govuk-!-margin-top-7">Generate a new link if it’s expired or shared by mistake. The old link will no longer work.</p>
+
+          <div class="govuk-button-group">
+            <%= form_with(url: update_bypass_id_admin_edition_path(local_edition), method: :patch, data: { module: "prevent-multiple-form-submissions" }) do %>
+              <%= render "govuk_publishing_components/components/button", {
+                text: "Generate new link",
+                secondary_quiet: true,
+              } %>
+            <% end %>
+
+            <%= form_with(url: destroy_bypass_id_admin_edition_path(local_edition), method: :delete, data: { module: "prevent-multiple-form-submissions" }) do %>
+              <%= render "govuk_publishing_components/components/button", {
+                text: "Delete link",
+                secondary_quiet: true,
+              } %>
+            <% end %>
+          </div>
+        <% else %>
+          <%= form_with(url: update_bypass_id_admin_edition_path(local_edition), method: :patch, data: { module: "prevent-multiple-form-submissions" }) do %>
+            <%= render "govuk_publishing_components/components/button", {
+              text: "Generate link",
+              secondary_quiet: true,
+            } %>
+          <% end %>
         <% end %>
       <% end %>
     <% end %>

app/components/admin/editions/show/preview_component.rb

@@ -19,6 +19,10 @@ def versioning_completed
     @versioning_completed ||= edition.versioning_completed?
   end
 
+  def token_generated?
+    edition.auth_bypass_id.present?
+  end
+
   def preview_link(link_text, href)
     link_to(link_text,
             href,

test/components/admin/editions/show/preview_component_test.rb

@@ -58,15 +58,39 @@ class Admin::Editions::Show::PreviewComponentTest < ViewComponent::TestCase
 
     render_inline(Admin::Editions::Show::PreviewComponent.new(edition:))
 
-    assert_selector ".govuk-details__summary-text", text: "Share document preview"
+    assert_selector ".govuk-details__summary-text", text: "Share preview link with someone else"
+  end
+
+  test "renders the copy link, regenerate and delete controls when the edition has a preview token" do
+    edition = build_stubbed(:publication, document: @document)
+
+    render_inline(Admin::Editions::Show::PreviewComponent.new(edition:))
+
+    assert_text "Anyone with a link can preview the content on GOV.UK."
+    assert_text "The link will expire on"
+    assert_text "The old link will no longer work."
+    assert_button "Copy link", exact: true, visible: :all
+    assert_button "Generate new link", exact: true, visible: :all
+    assert_button "Delete link", exact: true, visible: :all
+  end
+
+  test "renders only a generate control and no link when the edition has no preview token" do
+    edition = build_stubbed(:publication, document: @document, auth_bypass_id: nil)
+
+    render_inline(Admin::Editions::Show::PreviewComponent.new(edition:))
+
+    assert_text "Anyone with a link can preview the content on GOV.UK."
+    assert_button "Generate link", exact: true, visible: :all
+    assert_no_button "Copy link", exact: true, visible: :all
+    assert_no_button "Delete link", exact: true, visible: :all
   end
 
   test "does not render sharable preview functionality when edition is in a post-published state" do
     edition = build(:published_publication, document: @document)
 
     render_inline(Admin::Editions::Show::PreviewComponent.new(edition:))
 
-    assert_selector ".govuk-details__summary-text", text: "Share document preview", count: 0
+    assert_selector ".govuk-details__summary-text", text: "Share preview link with someone else", count: 0
   end
 
   test "does not render preview or sharable preview functionality and informs the user when versioning needs to be completed" do
@@ -76,7 +100,7 @@ class Admin::Editions::Show::PreviewComponentTest < ViewComponent::TestCase
     render_inline(Admin::Editions::Show::PreviewComponent.new(edition:))
 
     assert_selector "a[href='#{edition.public_url(draft: true)}']", text: "Preview on website (opens in new tab)", count: 0
-    assert_selector ".govuk-details__summary-text", text: "Share document preview", count: 0
+    assert_selector ".govuk-details__summary-text", text: "Share preview link with someone else", count: 0
     assert_selector ".govuk-inset-text", text: "To see the changes and share a document preview link, add a change note or mark the change type to minor."
   end
 

test/integration/shareable_preview_generate_new_link_test.rb

@@ -3,42 +3,76 @@
 
 class ShareablePreviewIntegrationTest < ActionDispatch::IntegrationTest
   extend Minitest::Spec::DSL
+  include Capybara::DSL
   include TaxonomyHelper
   include Admin::EditionRoutesHelper
 
   describe "shareable preview feature" do
-    context "for draft documents" do
+    before do
+      login_as create(:gds_editor)
+      topic_taxon = build(:taxon_hash)
+      stub_publishing_api_expanded_links_with_taxons(edition.content_id, [])
+      stub_publishing_api_links_with_taxons(edition.content_id, [topic_taxon["content_id"]])
+      visit admin_edition_path(edition)
+    end
+
+    context "for a draft with a preview link" do
       let(:edition) { create(:draft_publication) }
 
-      before do
-        create_setup(edition)
+      test "it shows the preview link with copy, regenerate and delete controls" do
+        open_share_preview_section
+
+        assert page.has_button?("Copy link")
+        assert page.has_button?("Generate new link")
+        assert page.has_button?("Delete link")
       end
 
-      test "it shows shareable preview feature" do
-        get admin_edition_path(edition)
-        assert_select ".govuk-details__summary-text", text: "Share document preview"
+      test "it regenerates the preview link, replacing the previous one" do
+        open_share_preview_section
+        previous_token = preview_token_in_page
+
+        click_button "Generate new link"
+        assert page.has_content?("New document preview link generated")
+
+        open_share_preview_section
+        assert_not_equal previous_token, preview_token_in_page
+      end
+
+      test "it deletes the preview link and can generate a new one from the empty state" do
+        open_share_preview_section
+
+        click_button "Delete link"
+        assert page.has_content?("Document preview link deleted")
+
+        open_share_preview_section
+        assert page.has_button?("Generate link")
+        assert page.has_no_button?("Copy link")
+        assert page.has_no_button?("Delete link")
+
+        click_button "Generate link"
+        assert page.has_content?("New document preview link generated")
+
+        open_share_preview_section
+        assert page.has_button?("Copy link")
+        assert page.has_button?("Delete link")
       end
     end
 
-    context "for published documents" do
+    context "for a published document" do
       let(:edition) { create(:published_publication) }
 
-      before do
-        create_setup(edition)
+      test "it does not show the shareable preview feature" do
+        assert_not page.has_content?("Share preview link with someone else")
       end
+    end
 
-      test "it does not show shareable preview feature" do
-        get admin_edition_path(edition)
-        refute_select ".govuk-details__summary-text", text: "Share document preview"
-      end
+    def open_share_preview_section
+      find(".govuk-details__summary", text: "Share preview link with someone else").click
     end
 
-    def create_setup(edition)
-      @user = create(:gds_editor)
-      login_as @user
-      topic_taxon = build(:taxon_hash)
-      stub_publishing_api_expanded_links_with_taxons(edition.content_id, [])
-      stub_publishing_api_links_with_taxons(edition.content_id, [topic_taxon["content_id"]])
+    def preview_token_in_page
+      preview_url = all("input").first.value
+      Rack::Utils.parse_query(URI(preview_url).query)["token"]
     end
   end
 end