Validation on model

Author: patrickpatrickpatrick

app/controllers/admin/editions_controller.rb

@@ -255,6 +255,7 @@ def permitted_edition_attributes
         topic_ids: [],
         topical_event_ids: [], # LEGACY
         topical_event_document_ids: [], # New
+        topical_event_links: [],
         related_detailed_guide_ids: [],
         role_appointment_ids: [],
         statistical_data_set_document_ids: [],

app/models/concerns/edition/topical_events.rb

@@ -26,14 +26,28 @@ def process_associations_before_save(edition)
     has_many :topical_event_memberships, dependent: :destroy, inverse_of: :edition, foreign_key: :edition_id
     has_many :topical_events, through: :topical_event_memberships, source: :topical_event
     # NEW
-    has_many :topical_event_links, -> { of_type "topical_event" }, class_name: "EditionLink", dependent: :destroy, inverse_of: :edition, foreign_key: :edition_id
+    has_many :topical_event_links, -> { of_type "topical_event" }, class_name: "EditionLink", dependent: :destroy, inverse_of: :edition, foreign_key: :edition_id, validate: false
     has_many :topical_event_documents, through: :topical_event_links, source: :document
 
+    validates_associated :topical_event_links
+    after_validation :replace_edition_link_errors
+
     add_trait Trait
   end
 
+  def replace_edition_link_errors
+    return unless errors[:topical_event_links]
+
+    errors.delete(:topical_event_links)
+
+    topical_event_links.each do |topical_event_link|
+      errors.add(:topical_event_document_ids, topical_event_link.errors.full_messages.join(",")) if topical_event_link.errors.present?
+    end
+  end
+
   # This method can be deleted when all legacy content types have been migrated to
   # being config-driven (which has its own implementation of the method).
+
   def can_be_associated_with_topical_events?
     true
   end

app/models/edition_link.rb

@@ -2,4 +2,11 @@ class EditionLink < ApplicationRecord
   belongs_to :edition
   belongs_to :document
   scope :of_type, ->(type) { where(link_type: type) }
+  validate :is_not_self
+
+  def is_not_self
+    return unless edition.document == document
+
+    errors.add(:base, "cannot include an association with this document (\"#{edition.title}\")")
+  end
 end

app/validators/edition_link_validator.rb

@@ -0,0 +1,3 @@
+class EditionLinkValidator < ActiveModel::Validator
+  def validate(record); end
+end

app/views/admin/configurable_content_blocks/select_with_search_tagging.html.erb

@@ -5,6 +5,6 @@
   error_items: errors_for(block.edition.errors, block.path.validation_error_attribute.to_sym, block.title),
   include_blank: true,
   heading_size: "m",
-  options: block.exclude_self(block.public_send("taggable_#{block.container}_container", block.value)),
+  options: block.public_send("taggable_#{block.container}_container", block.value),
   multiple: true,
 } %>

test/unit/app/models/edition_link.rb

@@ -0,0 +1,9 @@
+require "test_helper"
+
+class EditionLinkTest < ActiveSupport::TestCase
+  test "should be invalid if linking to itself" do
+    @standard_edition = create(:standard_edition)
+    edition_link = EditionLink.new(edition: @standard_edition, document: @standard_edition.document)
+    assert_not edition_link.valid?
+  end
+end