Use featurable trait for edition features

Author: ryanb-gds

app/controllers/admin/edition_featurings_controller.rb

@@ -6,7 +6,7 @@ class Admin::EditionsController < Admin::BaseController
   before_action :clean_edition_parameters, only: %i[create update]
   before_action :clear_scheduled_publication_if_not_activated, only: %i[create update]
   before_action :clear_response_form_file_cache, only: %i[create update]
-  before_action :find_edition, only: %i[show edit update revise diff confirm_destroy destroy update_bypass_id update_image_display_option]
+  before_action :find_edition, only: %i[show edit update revise diff confirm_destroy destroy update_bypass_id update_image_display_option features]
   before_action :prevent_modification_of_unmodifiable_edition, only: %i[update]
   before_action :delete_absent_edition_organisations, only: %i[create update]
   before_action :build_national_exclusion_params, only: %i[create update]
@@ -31,7 +31,7 @@ def enforce_permissions!
       enforce_permission!(:create, edition_class || Edition)
     when "create"
       enforce_permission!(:create, @edition)
-    when "edit", "update", "revise", "diff", "update_bypass_id", "update_image_display_option"
+    when "edit", "update", "revise", "diff", "update_bypass_id", "update_image_display_option", "features"
       enforce_permission!(:update, @edition)
     when "destroy", "confirm_destroy"
       enforce_permission!(:delete, @edition)

app/controllers/admin/editions_controller.rb

@@ -41,6 +41,7 @@ def load_parent
     @parent = WorldLocation.friendly.find(params[:world_location_news_id]).world_location_news if params[:world_location_news_id]
     @parent = Organisation.friendly.find(params[:organisation_id]) if params[:organisation_id]
     @parent = TopicalEvent.friendly.find(params[:topical_event_id]) if params[:topical_event_id]
+    @parent = StandardEdition.find(params[:standard_edition_id]) if params[:standard_edition_id]
   end
 
   def load_offsite_link

app/controllers/admin/offsite_links_controller.rb

@@ -35,6 +35,25 @@ def apply_change_type
     end
   end
 
+  def features
+    @feature_list = @edition.load_or_create_feature_list(params[:locale])
+    @locale = Locale.new(params[:locale] || :en)
+
+    filter_params = params.slice(:page, :type, :author, :title)
+                          .permit!
+                          .to_h
+                          .merge(
+                            state: "published",
+                            per_page: Admin::EditionFilter::GOVUK_DESIGN_SYSTEM_PER_PAGE,
+                            )
+
+    @filter = Admin::EditionFilter.new(Edition, current_user, filter_params)
+    @featurable_topical_events = TopicalEvent.active
+    @featurable_offsite_links = @edition.offsite_links
+
+    render :features
+  end
+
 private
 
   def edition_class

app/controllers/admin/standard_editions_controller.rb

@@ -3,15 +3,14 @@ module Edition::OffsiteLinks
 
   class Trait < Edition::Traits::Trait
     def process_associations_before_save(edition)
-      @edition.edition_offsite_links.each do |association|
-        edition.edition_offsite_links.build(association.attributes.except("id"))
+      @edition.offsite_links.each do |association|
+        edition.offsite_links.build(association.attributes.except("id"))
       end
     end
   end
 
   included do
-    has_many :edition_offsite_links, foreign_key: :edition_id, dependent: :destroy
-    has_many :offsite_links, through: :edition_offsite_links, validate: false
+    has_many :offsite_links, as: :parent
 
     add_trait Trait
   end

app/models/concerns/edition/offsite_links.rb

@@ -112,6 +112,10 @@ def url_is_permitted?(host)
   end
 
   def republish_parent_to_publishing_api
-    Whitehall::PublishingApi.republish_async(parent)
+    if parent.is_a? StandardEdition
+      Whitehall::PublishingApi.republish_document_async(parent.document)
+    else
+      Whitehall::PublishingApi.republish_async(parent)
+    end
   end
 end

app/models/configurable_associations/offsite_links.rb

@@ -2,6 +2,7 @@ class StandardEdition < Edition
   include Edition::Identifiable
   include Edition::Images
   include ::Attachable
+  include ::Featurable
   include Edition::AlternativeFormatProvider
   include Edition::RoleAppointments
   include Edition::TopicalEvents