Fix parent_document_url not being sent to asset manager for response-type attachments

When a consultation or call for evidence is published, `PublishAttachmentAssetJob` updates each attachment's metadata in asset manager. For attachments belonging to a ConsultationOutcome, ConsultationPublicFeedback, or CallForEvidenceOutcome, `parent_document_url` was never sent because the job guards with `respond_to?(:public_url)`, and neither ConsultationResponse nor CallForEvidenceResponse implemented that method.

I've extended ConsultationResponse and CallForEvidenceResponse, so the PublishAttachmentAssetJob can use their parent document's public URL for associated attachments' `parent_document_url`.

Known limitation: When saving a draft edition of a Consultation Outcome/Public Feedback or Call for Evidence Outcome, the `attachable_url` in AttachmentData is used to get the `parent_document_url` to be sent to Asset Manager. However, this will still return `nil`. This is because that method calls `visible_edition_for` which filters to Edition subclasses only, and neither ConsultationResponse nor CallForEvidenceResponse is an Edition. As a result, `parent_document_url` is only reliably set at publish time, not on every metadata update.

Extending `attachable_url` to handle non-edition attachables with a public URL would be great as a follow-up work.

Author: eYinka

app/models/call_for_evidence_response.rb

@@ -33,6 +33,8 @@ def access_limited_object
 
   delegate :unpublishing, to: :parent_attachable
 
+  delegate :public_url, to: :parent_attachable
+
   def can_order_attachments?
     true
   end

app/models/consultation_response.rb

@@ -33,6 +33,8 @@ def access_limited_object
 
   delegate :unpublishing, to: :parent_attachable
 
+  delegate :public_url, to: :parent_attachable
+
   def can_order_attachments?
     true
   end

test/unit/app/sidekiq/publish_attachment_asset_job_test.rb

@@ -59,5 +59,68 @@ class PublishAttachmentAssetJobTest < ActiveSupport::TestCase
         job.perform(attachment_data.id)
       end
     end
+
+    context "attachment belongs to a consultation outcome" do
+      let(:consultation) { create(:published_consultation, title: "my-consultation") }
+      let(:outcome) { create(:consultation_outcome, consultation:) }
+      let(:attachment_data) { create(:attachment_data, attachable: outcome) }
+      let(:attachment) { create(:file_attachment, attachable: outcome, attachment_data:) }
+
+      before do
+        attachment_data.attachments = [attachment]
+        attachment_data.save!
+      end
+
+      it "updates the asset with the parent consultation's public URL" do
+        AssetManager::AssetUpdater.expects(:call).with(
+          asset_manager_id,
+          { "draft" => false, "parent_document_url" => "https://www.test.gov.uk/government/consultations/my-consultation" },
+        )
+
+        job.perform(attachment_data.id)
+      end
+    end
+
+    context "attachment belongs to a consultation public feedback" do
+      let(:consultation) { create(:published_consultation, title: "my-consultation") }
+      let(:public_feedback) { create(:consultation_public_feedback, consultation:) }
+      let(:attachment_data) { create(:attachment_data, attachable: public_feedback) }
+      let(:attachment) { create(:file_attachment, attachable: public_feedback, attachment_data:) }
+
+      before do
+        attachment_data.attachments = [attachment]
+        attachment_data.save!
+      end
+
+      it "updates the asset with the parent consultation's public URL" do
+        AssetManager::AssetUpdater.expects(:call).with(
+          asset_manager_id,
+          { "draft" => false, "parent_document_url" => "https://www.test.gov.uk/government/consultations/my-consultation" },
+        )
+
+        job.perform(attachment_data.id)
+      end
+    end
+
+    context "attachment belongs to a call for evidence outcome" do
+      let(:call_for_evidence) { create(:published_call_for_evidence, title: "my-call-for-evidence") }
+      let(:outcome) { create(:call_for_evidence_outcome, call_for_evidence:) }
+      let(:attachment_data) { create(:attachment_data, attachable: outcome) }
+      let(:attachment) { create(:file_attachment, attachable: outcome, attachment_data:) }
+
+      before do
+        attachment_data.attachments = [attachment]
+        attachment_data.save!
+      end
+
+      it "updates the asset with the parent call for evidence's public URL" do
+        AssetManager::AssetUpdater.expects(:call).with(
+          asset_manager_id,
+          { "draft" => false, "parent_document_url" => "https://www.test.gov.uk/government/calls-for-evidence/my-call-for-evidence" },
+        )
+
+        job.perform(attachment_data.id)
+      end
+    end
   end
 end