Use image_usage.title in frontend

Consistently use `image_usage.title` when necessary and remove logic
that previously was present in the frontend to calculate the correct
title of an image usage.

Author: patrickpatrickpatrick

app/components/admin/edition_images/image_card_component.html.erb

@@ -1,7 +1,7 @@
 <%= render "govuk_publishing_components/components/summary_card", {
   id: "uploaded_#{image_usage.key}_image_card",
-  title: image_usage.label&.titleize || image_usage.key.titleize,
   summary_card_actions: summary_card_actions,
+  title: image_usage.title.upcase_first,
   rows: [
     {
       key: "Image",

app/components/admin/edition_images/image_upload_component.html.erb

@@ -1,9 +1,10 @@
 <%
   image_kind = image_usage.kinds.first
+  image_usage_title = image_usage.title.downcase
 
-  hint_text = ["A #{image_kind.display_name} image must be at least <strong>#{image_kind.valid_width}x#{image_kind.valid_height}</strong>."]
+  hint_text = ["#{image_usage_title.articleize.upcase_first} must be at least <strong>#{image_kind.valid_width}x#{image_kind.valid_height}</strong>."]
   unless image_usage.multiple
-    hint_text << " If you are uploading more than one image, <a class=\"govuk-link\" href=\"https://www.gov.uk/guidance/how-to-publish-on-gov-uk/images-and-videos\">read the image guidance</a> on using unique file names."
+    hint_text << " If you are uploading more than one #{image_usage_title}, <a class=\"govuk-link\" href=\"https://www.gov.uk/guidance/how-to-publish-on-gov-uk/images-and-videos\">read the image guidance</a> on using unique file names."
   end
 %>
 

app/components/admin/edition_images/lead_image_card_component.html.erb

@@ -6,7 +6,7 @@
 
 <%= render "govuk_publishing_components/components/summary_card", {
   id: "uploaded_#{image_usage.key}_image_card",
-  title: image_usage.label&.titleize || image_usage.key.titleize,
+  title: image_usage.title.upcase_first,
   summary_card_actions: summary_card_actions,
   rows: [
     {

app/models/configurable_document_types/case_study.json

@@ -99,7 +99,6 @@
           "caption_enabled": true
         },        
         "lead": {
-          "label": "lead",
           "kinds": ["default"],
           "multiple": false,
           "caption_enabled": true

app/models/configurable_document_types/government_response.json

@@ -115,7 +115,6 @@
           "caption_enabled": true
         },
         "lead": {
-          "label": "lead",
           "kinds": ["default"],
           "multiple": false,
           "caption_enabled": true

app/models/configurable_document_types/news_story.json

@@ -115,7 +115,6 @@
           "caption_enabled": true
         },
         "lead": {
-          "label": "lead",
           "kinds": ["default"],
           "multiple": false,
           "caption_enabled": true

app/models/configurable_document_types/press_release.json

@@ -115,7 +115,6 @@
           "caption_enabled": true
         },
         "lead": {
-          "label": "lead",
           "kinds": ["default"],
           "multiple": false,
           "caption_enabled": true

app/models/configurable_document_types/topical_event.json

@@ -181,7 +181,6 @@
       "enabled": true,
       "usages": {
         "header": {
-          "label": "header image",
           "kinds": ["topical_event_header"],
           "multiple": false,
           "caption_enabled": true

app/models/configurable_document_types/world_news_story.json

@@ -100,7 +100,6 @@
           "caption_enabled": true
         },
         "lead": {
-          "label": "lead",
           "kinds": ["default"],
           "multiple": false,
           "caption_enabled": true

app/views/admin/edition_images/new.html.erb

@@ -1,6 +1,6 @@
 <% content_for :context, "#{@edition.title}" %>
-<% content_for :page_title, "New #{@image_usage.label} image for #{@edition.format_name}" %>
-<% content_for :title, "New #{@image_usage.label} image for #{@edition.format_name}" %>
+<% content_for :page_title, "New #{@image_usage.title} for #{@edition.format_name}" %>
+<% content_for :title, "New #{@image_usage.title} for #{@edition.format_name}" %>
 <% content_for :error_summary, render(Admin::ErrorSummaryComponent.new(object: @images.flat_map { |image| image&.errors&.errors }, parent_class: "edition_images")) if @images.present? %>
 
 <div class="govuk-grid-row">