Capture same base path error and display to user

Instead of presenting a server error to the user if they try and create
an edition that has the base path of another published edition, the
error is now presented to the user.

Author: ChrisBAshton

app/controllers/admin/editions_controller.rb

@@ -97,6 +97,7 @@ def create
     @edition.destroy!
     build_edition
     build_edition_dependencies
+    @edition.errors.add(:title, "has been used before on GOV.UK, although the page may no longer exist. Please use another title")
     render :new
   end
 

app/models/document.rb

@@ -85,7 +85,6 @@ def first_edition_id
 
   def similar_slug_exists?
     scope = Document.where(document_type:)
-    sequence_separator = friendly_id_config.sequence_separator
 
     # slug is a nullable column, so we can't assume that it exists
     return false if slug.nil?
@@ -99,6 +98,8 @@ def similar_slug_exists?
     ).count > 1
   end
 
+  delegate :sequence_separator, to: :friendly_id_config
+
   def should_generate_new_friendly_id?
     sluggable_string.present?
   end

app/models/edition.rb

@@ -400,6 +400,10 @@ def base_path
     "/government/generic-editions/#{url_slug}"
   end
 
+  def base_path_without_sequence
+    base_path.split(document.sequence_separator).first
+  end
+
   def public_path(options = {})
     return if base_path.nil?
 

app/services/draft_edition_updater.rb

@@ -8,6 +8,8 @@ def perform!
   end
 
   def failure_reason
+    return @failure_reason if @failure_reason.present?
+
     if !edition.pre_publication?
       "A #{edition.state} edition may not be updated."
     elsif should_check_current_user_will_retain_access? && access_limit_excludes_current_user?

features/news-article.feature

@@ -0,0 +1,9 @@
+Feature: News article
+
+  Background:
+    Given I am an editor
+
+  Scenario: Creating a new draft publication with a reserved path
+    Given a published news article "Stubble to be Outlawed" exists
+    When I start drafting a new news article "Stubble to be Outlawed"
+    Then I should see an error of "Title has been used before on GOV.UK, although the page may no longer exist. Please use another title" on the new news article page

features/step_definitions/news_article_steps.rb

@@ -0,0 +1,12 @@
+When(/^I start drafting a new news article "([^"]*)"$/) do |title|
+  begin_drafting_news_article({ title: })
+  Whitehall::PublishingApi.unstub(:ensure_base_path_is_associated_with_this_content_id!)
+  Services.publishing_api.stubs(:lookup_content_id).returns("not a real content id")
+  click_button "Save and go to document summary"
+  Whitehall::PublishingApi.stubs(:ensure_base_path_is_associated_with_this_content_id!).returns(nil)
+end
+
+Then(/^I should see an error of "(.*)" on the new news article page$/) do |error|
+  expect(page).to have_selector(".gem-c-error-summary__list-item")
+  expect(page).to have_content(error.to_s)
+end

features/support/document_helper.rb

@@ -21,6 +21,11 @@ def begin_drafting_document(options)
     page.choose(options[:type].humanize)
     click_button("Next")
 
+    if options[:subtype]
+      page.choose(options[:subtype].humanize)
+      click_button("Next")
+    end
+
     if options[:locale]
       check "Create a foreign language only"
       select options[:locale], from: "Document language"
@@ -56,7 +61,7 @@ def begin_editing_document(title)
   end
 
   def begin_drafting_news_article(options)
-    begin_drafting_document(options.merge(type: "news_article", previously_published: false))
+    begin_drafting_document(options.merge(type: "news_article", subtype: "news_story", previously_published: false))
     fill_in_news_article_fields(**options.slice(:first_published, :announcement_type))
   end
 
@@ -117,8 +122,7 @@ def fill_in_worldwide_organisation_fields(world_location: "United Kingdom")
     fill_in "Logo formatted name", with: "Logo\r\nformatted\r\nname\r\n"
   end
 
-  def fill_in_news_article_fields(first_published: "2010-01-01", announcement_type: "News story")
-    select announcement_type, from: "News article type"
+  def fill_in_news_article_fields(first_published: "2010-01-01")
     checkbox_label = "This document has previously been published on another website"
     check checkbox_label
     within_conditional_reveal checkbox_label do

lib/whitehall/publishing_api.rb

@@ -69,7 +69,13 @@ def self.save_draft_translation(
 
         content.merge!(bulk_publishing: true) if bulk_publishing
 
-        ensure_base_path_is_associated_with_this_content_id!(content[:base_path], model_instance.content_id)
+        base_path = if model_instance.respond_to?(:base_path_without_sequence)
+                      model_instance.base_path_without_sequence
+                    else
+                      content[:base_path]
+                    end
+
+        ensure_base_path_is_associated_with_this_content_id!(base_path, model_instance.content_id)
 
         Services.publishing_api.put_content(presenter.content_id, content)
       end