use correct quotes

Author: patrickpatrickpatrick

app/components/admin/editions/document_type_change_summary.rb

@@ -30,15 +30,15 @@ def compute_diffs
       schema = @old_type.properties[key]
       {
         field: schema["title"] || key.humanize,
-        value: "Will be deleted. A '#{@new_type.label}' does not have a '#{schema['title'] || key.humanize}' field.",
+        value: "Will be deleted. A ‘#{@new_type.label}’ does not have a ‘#{schema['title'] || key.humanize}’ field.",
       }
     end
 
     @new_property_items = added_prop_keys.map do |key|
       schema = @new_type.properties[key]
       {
         field: schema["title"] || key.humanize,
-        value: "Will need to be added. A '#{@new_type.label}' has a '#{schema['title'] || key.humanize}' field. This field will be blank after the change.",
+        value: "Will need to be added. A ‘#{@new_type.label}’ has a ‘#{schema['title'] || key.humanize}’ field. This field will be blank after the change.",
       }
     end
 
@@ -47,7 +47,7 @@ def compute_diffs
 
       {
         field:,
-        value: "Will be deleted. A '#{@new_type.label}' does not have a '#{field}' association.",
+        value: "Will be deleted. A ‘#{@new_type.label}’ does not have a ‘#{field}’ association.",
       }
     end
 
@@ -56,7 +56,7 @@ def compute_diffs
 
       {
         field:,
-        value: "Will need to be added. A '#{@new_type.label}' has a '#{field}' association. This field will be blank after the change.",
+        value: "Will need to be added. A ‘#{@new_type.label}’ has a ‘#{field}’ association. This field will be blank after the change.",
       }
     end
 

app/models/configurable_document_types/government_response.json

@@ -1,7 +1,7 @@
 {
   "key": "government_response",
   "title": "Government response",
-  "description": "Government statements in response to media coverage, such as rebuttals and 'myth busters'. Do not use for: statements to Parliament. Use the 'Speech' format for those.",
+  "description": "Government statements in response to media coverage, such as rebuttals and ‘myth busters’. Do not use for: statements to Parliament. Use the ‘Speech’ format for those.",
   "forms": {
     "documents": {
       "fields": {

app/models/configurable_document_types/press_release.json

@@ -1,7 +1,7 @@
 {
   "key": "press_release",
   "title": "Press release",
-  "description": "Unedited press releases as sent to the media, and official statements from the organisation or a minister. Do not use for: statements to Parliament. Use the 'Speech' format for those.",
+  "description": "Unedited press releases as sent to the media, and official statements from the organisation or a minister. Do not use for: statements to Parliament. Use the ‘Speech’ format for those.",
   "forms": {
     "documents": {
       "fields": {

app/models/publication_type.rb

@@ -8,20 +8,20 @@ class PublicationType
   FORMAT_ADVICE = {
     1 => "<p>A policy paper explains the government’s position on something. It doesn’t include instructions on how to carry out a task, only the policy itself and how it’ll be implemented.</p><p>Read the <a href=\"https://www.gov.uk/guidance/content-design/content-types#policy-paper\" target=\"_blank\" class=\"govuk-link\">policy papers guidance</a> in full.</p>",
     2 => "<p>Cost-benefit analyses and other assessments of the impact of proposed initiatives, or changes to regulations or legislation.</p>",
-    3 => "<p>Non-statutory guidance publications. Includes: manuals, handbooks and other documents that offer advice.</p><p>Do not use for: statutory guidance (use the 'statutory guidance' publication type) or guidance about completing a form (attach to same publication as the form itself).</p>",
-    4 => "<p>Pro-forma or form documents that need to be completed by the user. Can include guidance on how to fill in forms (ie no need to create a separate 'guidance' publication for form instructions).</p>",
+    3 => "<p>Non-statutory guidance publications. Includes: manuals, handbooks and other documents that offer advice.</p><p>Do not use for: statutory guidance (use the ‘statutory guidance’ publication type) or guidance about completing a form (attach to same publication as the form itself).</p>",
+    4 => "<p>Pro-forma or form documents that need to be completed by the user. Can include guidance on how to fill in forms (ie no need to create a separate ‘guidance’ publication for form instructions).</p>",
     5 => "<p>Statistics governed by the UK Statistics Authority and produced by members of the Government Statistical Service.</p>",
     6 => "<p>Research and evaluation papers. Can be conducted by government, commissioned by government or independent of government.</p>",
-    7 => "<p>Publications about what an organisation does (eg business plans, annual reports, accounts), or any plans that affect the organisation (eg structural reform plans, efficiency reviews). Corporate reports are shown automatically on the organisation’s 'What we do' page.</p>",
-    8 => "<p>Ministerial or departmental responses (eg to campaign letters), announcements, or statements;regularly issued circulars or bulletins (eg fire service circulars), official correspondence to professionals (eg 'Dear chief planning officer' letters);letters to individuals or organisations that are published to share with a wider audience than their original recipient;online versions of e-bulletins or newsletters.</p><p>Do not use for: minutes, agendas or other meeting papers. Attach them to relevant 'policy detail', 'team' or 'our governance' pages instead.</p>",
+    7 => "<p>Publications about what an organisation does (eg business plans, annual reports, accounts), or any plans that affect the organisation (eg structural reform plans, efficiency reviews). Corporate reports are shown automatically on the organisation’s ‘What we do’ page.</p>",
+    8 => "<p>Ministerial or departmental responses (eg to campaign letters), announcements, or statements;regularly issued circulars or bulletins (eg fire service circulars), official correspondence to professionals (eg ‘Dear chief planning officer‘ letters);letters to individuals or organisations that are published to share with a wider audience than their original recipient;online versions of e-bulletins or newsletters.</p><p>Do not use for: minutes, agendas or other meeting papers. Attach them to relevant ‘policy detail’, ’team’ or ‘our governance’ pages instead.</p>",
     10 => "<p>Information made available about departmental operations with the intent of making government more transparent.Includes organisation charts, staff survey results, departmental spending, salaries, contracts, meetings with ministers, etc.</p><p>Do not use for: FOI responses.</p>",
     12 => "<p>Responses to Freedom of Information requests. Ensure the title describes specifically what the request is about.</p>",
     13 => "<p>Leaflets, posters, fact sheets and marketing collateral.</p>",
     14 => "<p>Reviews, inquiries and other reports commissioned from or conducted by independent (ie non-governmental) bodies for consideration by the government.</p>",
     15 => "<p>Official Statistics that have been produced in accordance with the Code of Practice for Official Statistics, which is indicated using the Accredited Official Statistics quality mark.</p>",
     17 => "<p>Drawn maps and geographical data.</p>",
     18 => "<p>Treaties and memoranda of understanding between the UK and other nations.</p>",
-    19 => "<p>Guidance which relevant users are legally obliged to follow. (For non-statutory guidance publications, use the 'guidance' sub-type).</p>",
+    19 => "<p>Guidance which relevant users are legally obliged to follow. (For non-statutory guidance publications, use the ‘guidance’ sub-type).</p>",
     20 => "<p>Permit and licence applications published temporarily for public awareness.</p>",
     21 => "<p>Formal decisions by tribunals, regulators or adjudicators (including courts and Secretaries of State).</p>",
     22 => "<p>Regulations imposed by an independent regulatory authority only.</p><p>Do not use for: statutory guidance.</p>",

app/views/admin/editions/edit.html.erb

@@ -39,7 +39,7 @@
 
       <% unless @edition.editable? %>
         <%= render "govuk_publishing_components/components/inset_text", {} do %>
-          This is a read-only view of the current (<%= @edition.state %>) edition. To edit, please return to the summary page and choose 'Create new edition'.
+          This is a read-only view of the current (<%= @edition.state %>) edition. To edit, please return to the summary page and choose ‘Create new edition’.
         <% end %>
       <% end %>
 

app/views/admin/speeches/_form.html.erb

@@ -1,6 +1,6 @@
 <div class="format-advice">
   <p class="govuk-body"><strong>Use this format for:</strong> Public speeches by ministers or other named spokespeople, ministerial statements to Parliament and bylined articles.</p>
-  <p class="govuk-body">Do not use for: statements <em>not</em> made to Parliament (use the 'news article' format for those).</p>
+  <p class="govuk-body">Do not use for: statements <em>not</em> made to Parliament (use the ‘news article’ format for those).</p>
 </div>
 
 <%= standard_edition_form(edition) do |form| %>

app/views/admin/standard_editions/change_type_preview.html.erb

@@ -11,7 +11,7 @@
     <h1 class="govuk-heading-l"><%= page_heading %></h1>
 
     <p class="govuk-body">
-      You're about to change the document type of '<%= @edition.title %>'
+      You're about to change the document type of ‘<%= @edition.title %>’
       from <strong><%= @old_type.label %></strong>
       to <strong><%= @new_type.label %></strong>. A summary of what this change means is shown below. Please review carefully before confirming the change.
     </p>

app/views/admin/statistical_data_sets/_form.html.erb

@@ -1,5 +1,5 @@
 <div class="format-advice">
-  <p class="govuk-body"><strong>Use this format for:</strong> Frequently updated ('live') statistical data files.</p>
+  <p class="govuk-body"><strong>Use this format for:</strong> Frequently updated (‘live’) statistical data files.</p>
   <p class="govuk-body">Do not use for: less frequently updated (eg quarterly) data. Use a publication (subtype: statistics) instead.</p>
 </div>
 

spec/javascripts/admin/modules/edition-form.spec.js

@@ -178,7 +178,7 @@ describe('GOVUK.Modules.EditionForm', function () {
 
   function subtypeFields() {
     return (
-      "<div class=\"app-view-edition-form__subtype-fields js-app-view-edition-form__subtype-fields\" data-format-advice=\"{&quot;1&quot;:&quot;\u003cp\u003eNews written exclusively for GOV.UK which users need, can act on and can’t get from other sources. Avoid duplicating press releases.\u003c/p\u003e&quot;,&quot;2&quot;:&quot;\u003cp\u003eUnedited press releases as sent to the media, and official statements from the organisation or a minister.\u003c/p\u003e\u003cp\u003eDo \u003cem\u003enot\u003c/em\u003e use for: statements to Parliament. Use the 'Speech' format for those.\u003c/p\u003e&quot;,&quot;3&quot;:&quot;\u003cp\u003eGovernment statements in response to media coverage, such as rebuttals and 'myth busters'.\u003c/p\u003e\u003cp\u003eDo \u003cem\u003enot\u003c/em\u003e use for: statements to Parliament. Use the 'Speech' format for those.\u003c/p\u003e&quot;,&quot;4&quot;:&quot;\u003cp\u003eAnnouncements specific to one or more world location. Do not duplicate news published by another department.\u003c/p\u003e&quot;}\">" +
+      '<div class="app-view-edition-form__subtype-fields js-app-view-edition-form__subtype-fields" data-format-advice="{&quot;1&quot;:&quot;\u003cp\u003eNews written exclusively for GOV.UK which users need, can act on and can’t get from other sources. Avoid duplicating press releases.\u003c/p\u003e&quot;,&quot;2&quot;:&quot;\u003cp\u003eUnedited press releases as sent to the media, and official statements from the organisation or a minister.\u003c/p\u003e\u003cp\u003eDo \u003cem\u003enot\u003c/em\u003e use for: statements to Parliament. Use the ‘Speech’ format for those.\u003c/p\u003e&quot;,&quot;3&quot;:&quot;\u003cp\u003eGovernment statements in response to media coverage, such as rebuttals and ‘myth busters’.\u003c/p\u003e\u003cp\u003eDo \u003cem\u003enot\u003c/em\u003e use for: statements to Parliament. Use the \'Speech\' format for those.\u003c/p\u003e&quot;,&quot;4&quot;:&quot;\u003cp\u003eAnnouncements specific to one or more world location. Do not duplicate news published by another department.\u003c/p\u003e&quot;}">' +
       '<div class="govuk-form-group gem-c-select">' +
       '<label class="govuk-label govuk-label--s" for="edition_news_article_type_id">News article type</label>' +
       '<select name="edition[news_article_type_id]" id="edition_news_article_type_id" class="govuk-select gem-c-select__select--full-width">' +

test/components/admin/editions/document_type_change_summary_test.rb

@@ -51,23 +51,23 @@ def build_type(label:, properties: {}, associations: [])
 
     # Lost field (image)
     assert_text "Custom lead image"
-    assert_text "Will be deleted. A 'New type' does not have a 'Custom lead image' field."
+    assert_text "Will be deleted. A ‘New type’ does not have a ‘Custom lead image’ field."
 
     # New field (summary)
     assert_text "Summary"
-    assert_text "Will need to be added. A 'New type' has a 'Summary' field. This field will be blank after the change."
+    assert_text "Will need to be added. A ‘New type’ has a ‘Summary’ field. This field will be blank after the change."
 
     # Lost association (world_locations)
     assert_text "World locations"
-    assert_text "Will be deleted. A 'New type' does not have a 'World locations' association."
+    assert_text "Will be deleted. A ‘New type’ does not have a ‘World locations’ association."
 
     # Association with a different label to name
     assert_text "Ministers"
-    assert_text "Will be deleted. A 'New type' does not have a 'Ministers' association."
+    assert_text "Will be deleted. A ‘New type’ does not have a ‘Ministers’ association."
 
     # New association (topical_events)
     assert_text "Topical events"
-    assert_text "Will need to be added. A 'New type' has a 'Topical events' association. This field will be blank after the change."
+    assert_text "Will need to be added. A ‘New type’ has a ‘Topical events’ association. This field will be blank after the change."
 
     assert_text "Organisations"
     assert_text "These associations will be carried over, you will not have to fill them in again."