Update document type change summary copy

- Add `common_association_items` to display associations that will not
be changed by the document type change
- Add `association_to_label` for associations that have different labels
in the interface to how they are referenced in the schema

Author: patrickpatrickpatrick

app/components/admin/editions/document_type_change_summary.html.erb

@@ -13,7 +13,7 @@
 <% if lost_association_items.any? || new_association_items.any? %>
   <%= render "govuk_publishing_components/components/summary_list", {
     title: "Associations",
-    items: lost_association_items + new_association_items,
+    items: lost_association_items + new_association_items + common_association_items,
   } %>
 <% else %>
   <h3 class="govuk-heading-m">Associations</h3>

app/components/admin/editions/document_type_change_summary.rb

@@ -2,12 +2,16 @@ class Admin::Editions::DocumentTypeChangeSummary < ViewComponent::Base
   attr_reader :lost_property_items,
               :new_property_items,
               :lost_association_items,
-              :new_association_items
+              :new_association_items,
+              :common_association_items
 
   def initialize(edition:, old_type:, new_type:)
     @edition = edition
     @old_type = old_type
     @new_type = new_type
+    @association_to_label = {
+      "ministerial_role_appointments" => "Ministers",
+    }
 
     compute_diffs
   end
@@ -19,6 +23,7 @@ def compute_diffs
     added_prop_keys   = @new_type.properties.keys - @old_type.properties.keys # will need populating
     removed_assoc_keys = @old_type.associations.map { |a| a["key"] } - @new_type.associations.map { |a| a["key"] }
     added_assoc_keys   = @new_type.associations.map { |a| a["key"] } - @old_type.associations.map { |a| a["key"] }
+    common_assoc_keys = @new_type.associations.map { |a| a["key"] } & @old_type.associations.map { |a| a["key"] }
 
     @lost_property_items = removed_prop_keys.map do |key|
       schema = @old_type.properties[key]
@@ -36,21 +41,18 @@ def compute_diffs
       }
     end
 
-    @lost_association_items = removed_assoc_keys.map do |key|
-      field = key.humanize
-      
-      {
-        field:,
-        value: "Will be deleted. A ‘#{@new_type.label}’ does not have a ‘#{field}’ association.",
-      }
-    end
+    @lost_association_items = build_association_items(removed_assoc_keys, @new_type.label, proc { |label, field| "Will be deleted. A ‘#{label}’ does not have a ‘#{field}’ association." })
+    @new_association_items = build_association_items(added_assoc_keys, @new_type.label, proc { |label, field| "Will need to be added. A ‘#{label}’ has a ‘#{field}’ association. This field will be blank after the change." })
+    @common_association_items = build_association_items(common_assoc_keys, @new_type.label, proc { "These associations will be carried over, you will not have to fill them in again." })
+  end
 
-    @new_association_items = added_assoc_keys.map do |key|
-      field = key.humanize
+  def build_association_items(items, label, value)
+    items.map do |key|
+      field = @association_to_label[key] || key.humanize
 
       {
         field:,
-        value: "Will need to be added. A ‘#{@new_type.label}’ has a ‘#{field}’ association. This field will be blank after the change.",
+        value: value.call(label, field),
       }
     end
   end

test/components/admin/editions/document_type_change_summary_test.rb

@@ -19,6 +19,7 @@ def build_type(label:, properties: {}, associations: [])
       associations: [
         { "key" => "organisations" },
         { "key" => "world_locations" },
+        { "key" => "ministerial_role_appointments" },
       ],
     )