Skip to content

Commit d3d12ea

Browse files
committed
fix all the tests?
1 parent 023d703 commit d3d12ea

3 files changed

Lines changed: 8 additions & 4 deletions

File tree

test/test_helper.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,8 @@ class ActiveSupport::TestCase
7878
TaxonValidator.any_instance.stubs(:validate)
7979
# Prevent publishing API base path checks from interfering with tests
8080
Whitehall::PublishingApi.stubs(:ensure_base_path_is_associated_with_this_content_id!).returns(nil)
81+
# Set up default test type StandardEdition
82+
ConfigurableDocumentType.setup_test_types(build_configurable_document_type("test_type"))
8183
end
8284

8385
teardown do

test/unit/app/models/concerns/default_lead_image_test.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,13 @@ class DefaultLeadImageTest < ActiveSupport::TestCase
3131
end
3232

3333
test "#placeholder_image_url returns world news placeholder for world news stories" do
34+
ConfigurableDocumentType.setup_test_types(build_configurable_document_type("world_news_story"))
3435
edition = build(:standard_edition, configurable_document_type: "world_news_story")
3536
assert_equal "https://assets.publishing.service.gov.uk/media/5e985599d3bf7f3fc943bbd8/UK_government_logo.jpg", edition.placeholder_image_url
3637
end
3738

3839
test "#placeholder_image_url returns general placeholder for non-world news stories" do
40+
ConfigurableDocumentType.setup_test_types(build_configurable_document_type("news_article"))
3941
edition = build(:standard_edition, configurable_document_type: "news_article")
4042
assert_equal "https://assets.publishing.service.gov.uk/media/5e59279b86650c53b2cefbfe/placeholder.jpg", edition.placeholder_image_url
4143
end

test/unit/app/models/configurable_associations/topical_event_documents_test.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
class TopicalEventsDocumentsTest < ActiveSupport::TestCase
44
test "it presents the selected topical event document links" do
5-
ConfigurableDocumentType.setup_test_types(build_configurable_document_type("topical_event"))
5+
ConfigurableDocumentType.setup_test_types(build_configurable_document_type("test_type").merge(build_configurable_document_type("topical_event")))
66
topical_events = create_list(:standard_edition, 3, configurable_document_type: "topical_event")
77
edition = build(:draft_standard_edition, {
88
topical_event_documents: [topical_events.first.document, topical_events.last.document],
@@ -27,7 +27,7 @@ class TopicalEventDocumentsRenderingTest < ActionView::TestCase
2727
test "it does not render the topical events form control if configurable documents are disabled" do
2828
@test_strategy.switch!(:configurable_document_types, false)
2929

30-
ConfigurableDocumentType.setup_test_types(build_configurable_document_type("topical_event"))
30+
ConfigurableDocumentType.setup_test_types(build_configurable_document_type("test_type").merge(build_configurable_document_type("topical_event")))
3131
topical_events = create_list(:published_standard_edition, 3, configurable_document_type: "topical_event")
3232
edition = build(:draft_standard_edition, {
3333
topical_event_documents: [topical_events.first.document, topical_events.last.document],
@@ -42,7 +42,7 @@ class TopicalEventDocumentsRenderingTest < ActionView::TestCase
4242
end
4343

4444
test "it renders topical events form control" do
45-
ConfigurableDocumentType.setup_test_types(build_configurable_document_type("topical_event"))
45+
ConfigurableDocumentType.setup_test_types(build_configurable_document_type("test_type").merge(build_configurable_document_type("topical_event")))
4646
topical_events = create_list(:published_standard_edition, 3, configurable_document_type: "topical_event")
4747
edition = build(:draft_standard_edition, {
4848
topical_event_documents: [topical_events.first.document, topical_events.last.document],
@@ -57,7 +57,7 @@ class TopicalEventDocumentsRenderingTest < ActionView::TestCase
5757
end
5858

5959
test "it renders topical events form control with pre-selected options" do
60-
ConfigurableDocumentType.setup_test_types(build_configurable_document_type("topical_event"))
60+
ConfigurableDocumentType.setup_test_types(build_configurable_document_type("test_type").merge(build_configurable_document_type("topical_event")))
6161
topical_events = create_list(:published_standard_edition, 3, configurable_document_type: "topical_event")
6262
edition = build(:draft_standard_edition, {
6363
topical_event_documents: [topical_events.first.document],

0 commit comments

Comments
 (0)