Remove obsolete 'publishing_api_payload' method from configurable block models

Based on the new schema refactor to use "forms" property, we have now moved publishing api presenting to our new block abstraction method so this is no longer needed.

See `app/presenters/publishing_api/payload_builder/block_content.rb`

Author: eYinka

app/models/configurable_content_blocks/default_date.rb

@@ -1,9 +1,5 @@
 module ConfigurableContentBlocks
   class DefaultDate
-    def publishing_api_payload(content)
-      content&.rfc3339
-    end
-
     def to_partial_path
       "admin/configurable_content_blocks/default_date"
     end

app/models/configurable_content_blocks/default_object.rb

@@ -9,20 +9,5 @@ def initialize(block_factory)
     def to_partial_path
       "admin/configurable_content_blocks/default_object"
     end
-
-    def publishing_api_payload(schema, content)
-      output = {}
-      schema["properties"].each do |property_key, property_schema|
-        block = block_factory.build(property_schema["type"], property_schema["format"] || "default")
-        leaf_block = !%w[object array].include?(property_schema["type"])
-        payload = leaf_block ? block.publishing_api_payload(content[property_key]) : block.publishing_api_payload(property_schema, content[property_key])
-
-        next if payload.nil?
-
-        output.merge!({ property_key.to_sym => payload })
-      end
-
-      output
-    end
   end
 end

app/models/configurable_content_blocks/default_string.rb

@@ -1,9 +1,5 @@
 module ConfigurableContentBlocks
   class DefaultString
-    def publishing_api_payload(content)
-      content
-    end
-
     def to_partial_path
       "admin/configurable_content_blocks/default_string"
     end

app/models/configurable_content_blocks/govspeak.rb

@@ -10,12 +10,6 @@ def initialize(images = [], attachments = [])
       @attachments = attachments
     end
 
-    def publishing_api_payload(content)
-      return nil if content.nil?
-
-      govspeak_to_html(content, images: @images, attachments: @attachments)
-    end
-
     def to_partial_path
       "admin/configurable_content_blocks/govspeak"
     end

app/models/configurable_content_blocks/image_select.rb

@@ -6,17 +6,6 @@ def initialize(images = [])
       @images = images
     end
 
-    def publishing_api_payload(content)
-      return nil if content.nil?
-
-      if (selected_image = images.find { |image| image.image_data.id == content })&.image_data&.all_asset_variants_uploaded?
-        {
-          url: selected_image.url,
-          caption: image_caption(selected_image),
-        }.compact
-      end
-    end
-
     def to_partial_path
       "admin/configurable_content_blocks/image_select"
     end

app/models/configurable_content_blocks/lead_image_select.rb

@@ -8,28 +8,6 @@ def initialize(images = [], default_lead_image: nil, placeholder_image_url: nil)
       @default_lead_image = default_lead_image
     end
 
-    def publishing_api_payload(content)
-      selected_image = images.find { |image| image.image_data.id == content.to_i }
-      if selected_image
-        if selected_image.image_data&.all_asset_variants_uploaded?
-          # The payload for lead image must include a "high resolution url", used for metadata: https://github.com/alphagov/frontend/blob/693747dc55d9a42ba209789e6861d9b592b48c8e/spec/system/news_article_spec.rb#L65
-          # The "url" is used for the lead image rendered on the document page.
-          return {
-            high_resolution_url: selected_image.image_data.url(:s960),
-            url: selected_image.image_data.url(:s300),
-            caption: lead_image_caption(selected_image),
-          }.compact
-        end
-      elsif default_lead_image&.all_asset_variants_uploaded?
-        return {
-          high_resolution_url: default_lead_image.url(:s960),
-          url: default_lead_image.url(:s300),
-        } # default images do not have captions
-      end
-
-      placeholder_payload
-    end
-
     def to_partial_path
       "admin/configurable_content_blocks/lead_image_select"
     end

test/unit/app/models/configurable_content_blocks/default_date_test.rb

@@ -1,12 +1,5 @@
 require "test_helper"
 
-class ConfigurableContentBlocks::DefaultDateTest < ActiveSupport::TestCase
-  test "it presents the content" do
-    payload = ConfigurableContentBlocks::DefaultDate.new.publishing_api_payload(Time.zone.now)
-    assert_equal(Time.zone.now.rfc3339, payload)
-  end
-end
-
 class ConfigurableContentBlocks::DefaultDateRenderingTest < ActionView::TestCase
   setup do
     @schema = {

test/unit/app/models/configurable_content_blocks/default_string_test.rb

@@ -1,12 +1,5 @@
 require "test_helper"
 
-class ConfigurableContentBlocks::DefaultStringTest < ActiveSupport::TestCase
-  test "it presents the content" do
-    payload = ConfigurableContentBlocks::DefaultString.new.publishing_api_payload("foo")
-    assert_equal("foo", payload)
-  end
-end
-
 class ConfigurableContentBlocks::DefaultStringRenderingTest < ActionView::TestCase
   setup do
     @schema = {

test/unit/app/models/configurable_content_blocks/govspeak_test.rb

@@ -1,26 +1,5 @@
 require "test_helper"
 
-class ConfigurableContentBlocks::GovspeakTest < ActiveSupport::TestCase
-  test "it presents the govspeak content as HTML, including images and attachments" do
-    image = create(:image)
-    attachment = create(:file_attachment)
-    govspeak = "A paragraph followed by an image:\n[Image: #{image.filename}]\n[Attachment: #{attachment.filename}]"
-    images = [image]
-    attachments = [attachment]
-    payload = ConfigurableContentBlocks::Govspeak.new(images, attachments).publishing_api_payload(govspeak)
-    doc = Nokogiri::HTML(payload)
-    assert_not doc.css("a[href=\"#{attachment.url}\"]").empty?
-    assert_not doc.css("img[src=\"#{image.embed_url}\"]").empty?
-    assert_match(/A paragraph followed by an image/m, doc.text)
-  end
-
-  test "does not have a publishing api payload if content is nil" do
-    payload = ConfigurableContentBlocks::Govspeak.new.publishing_api_payload(nil)
-
-    assert_nil payload
-  end
-end
-
 class ConfigurableContentBlocks::GovspeakRenderingTest < ActionView::TestCase
   setup do
     @schema = {

test/unit/app/models/configurable_content_blocks/image_select_test.rb

@@ -1,43 +1,5 @@
 require "test_helper"
 
-class ConfigurableContentBlocks::ImageSelectTest < ActiveSupport::TestCase
-  test "it loads the correct image and presents the image attributes" do
-    images = [create(:image), create(:image, caption: "Example caption")]
-    payload = ConfigurableContentBlocks::ImageSelect.new(images).publishing_api_payload(images[1].image_data.id)
-
-    assert_equal({
-      url: images[1].url,
-      caption: images[1].caption,
-    }, payload)
-  end
-
-  test "it does not send the the caption if nil" do
-    image = create(:image, caption: nil)
-    payload = ConfigurableContentBlocks::ImageSelect.new([image]).publishing_api_payload(image.image_data.id)
-
-    assert_equal({
-      url: image.url,
-    }, payload)
-  end
-
-  test "does not have a publishing api payload if content is nil" do
-    image = create(:image)
-    payload = ConfigurableContentBlocks::ImageSelect.new([image]).publishing_api_payload(nil)
-
-    assert_nil payload
-  end
-
-  test "does not have a publishing api payload if selected image's assets are not ready" do
-    images = create_list(:image, 3)
-    images[1].image_data.assets = []
-    images[1].image_data.save!
-
-    payload = ConfigurableContentBlocks::ImageSelect.new(images).publishing_api_payload(images[1].image_data.id)
-
-    assert_nil payload
-  end
-end
-
 class ConfigurableContentBlocks::ImageSelectRenderingTest < ActionView::TestCase
   setup do
     @schema = {