Handle association with different label in type change summary

Author: patrickpatrickpatrick

app/components/admin/editions/document_type_change_summary.rb

@@ -2,8 +2,7 @@ class Admin::Editions::DocumentTypeChangeSummary < ViewComponent::Base
   attr_reader :lost_property_items,
               :new_property_items,
               :lost_association_items,
-              :new_association_items,
-              :common_association_items
+              :new_association_items
 
   def initialize(edition:, old_type:, new_type:)
     @edition = edition
@@ -20,7 +19,6 @@ def compute_diffs
     added_prop_keys   = @new_type.properties.keys - @old_type.properties.keys # will need populating
     removed_assoc_keys = @old_type.associations.map { |a| a["key"] } - @new_type.associations.map { |a| a["key"] }
     added_assoc_keys   = @new_type.associations.map { |a| a["key"] } - @old_type.associations.map { |a| a["key"] }
-    common_assoc_keys = @old_type.associations.map { |a| a["key"] } & @new_type.associations.map { |a| a["key"] } # are present in both
 
     @lost_property_items = removed_prop_keys.map do |key|
       schema = @old_type.properties[key]
@@ -64,12 +62,5 @@ def compute_diffs
         value: "These associations will be carried over, you will not have to fill them in again.",
       }
     end
-
-    @common_association_items = common_assoc_keys.map do |key|
-      {
-        field: key.humanize,
-        value: "These associations will be carried over, you will not have to fill them in again.",
-      }
-    end
   end
 end

test/components/admin/editions/document_type_change_summary_test.rb

@@ -19,6 +19,7 @@ def build_type(label:, properties: {}, associations: [])
       associations: [
         { "key" => "organisations" },
         { "key" => "world_locations" },
+        { "key" => "ministerial_role_appointments" },
       ],
     )
 
@@ -64,6 +65,10 @@ def build_type(label:, properties: {}, associations: [])
     assert_text "Ministers"
     assert_text "Will be deleted. A ‘New type’ does not have a ‘Ministers’ association."
 
+    # Association with a different label to name
+    assert_text "Ministers"
+    assert_text "Will be deleted. A 'New type' does not have a 'Ministers' association."
+
     # New association (topical_events)
     assert_text "Topical events"
     assert_text "Will need to be added. A ‘New type’ has a ‘Topical events’ association. This field will be blank after the change."