Support access-limited-by-default formats

For edition types that are access-limited by default (e.g. StatisticalDataSet, official/national statistics Publications), pre-select organisation access limiting and pre-fill the organisation select with the edition's lead organisations.

A shared Edition#prefill_default_access_limiting_organisations is called from the access-limited form's edit action and the main edition form's new and edit actions, so the behaviour is consistent when creating or editing.

Author: GDSNewt

app/controllers/admin/edition_access_limited_controller.rb

@@ -5,7 +5,9 @@ class Admin::EditionAccessLimitedController < Admin::BaseController
   before_action :enforce_permissions!
   before_action :clean_organisation_params, only: %i[update]
 
-  def edit; end
+  def edit
+    @edition.prefill_default_access_limiting_organisations
+  end
 
   def update
     editorial_remark = edition_params.delete(:editorial_remark)

app/controllers/admin/editions_controller.rb

@@ -89,7 +89,9 @@ def show
     end
   end
 
-  def new; end
+  def new
+    @edition.prefill_default_access_limiting_organisations
+  end
 
   def create
     if updater.can_perform? && @edition.save
@@ -110,6 +112,7 @@ def create
 
   def edit
     @edition.open_for_editing_as(current_user) if @edition.editable?
+    @edition.prefill_default_access_limiting_organisations
     fetch_version_and_remark_trails
   end
 

app/models/concerns/edition/limited_access.rb

@@ -43,6 +43,13 @@ def set_access_limited
     end
   end
 
+  def prefill_default_access_limiting_organisations
+    return unless Flipflop.access_limiting_organisations_ui?
+    return unless access_limited_by_default? && access_limiting_organisations.empty?
+
+    self.access_limiting_organisations = lead_organisations
+  end
+
   def accessible_to?(user)
     user.present? && Whitehall::Authority::Enforcer.new(user, self).can?(:see)
   end

test/functional/admin/statistical_data_sets_controller_test.rb

@@ -17,6 +17,21 @@ class Admin::StatisticalDataSetsControllerTest < ActionController::TestCase
   should_allow_scheduled_publication_of :statistical_data_set
   should_allow_access_limiting_of :statistical_data_set
 
+  view_test "GET :new pre-selects organisation access limiting and pre-fills the creator's organisation for default-access-limited types when access_limiting_organisations_ui flag is on" do
+    StatisticalDataSet.unstub(:access_limited_by_default?)
+    feature_flags.switch! :access_limiting_organisations_ui, true
+
+    organisation = create(:organisation)
+    login_as create(:writer, organisation:)
+
+    get :new
+
+    assert_select "input[name='edition[access_limiting]'][value='organisations'][checked=checked]"
+    assert_select "select[name='edition[access_limiting_organisation_ids][]']" do
+      assert_select "option[selected='selected'][value='#{organisation.id}']"
+    end
+  end
+
   def controller_attributes_for(edition_type, attributes = {})
     super.except(:alternative_format_provider).reverse_merge(
       alternative_format_provider_id: create(:alternative_format_provider).id,