Skip to content

Commit 4ca1579

Browse files
authored
Chore: upgrade Alpine.js version, fix version detection issues + prep 0.1.0 (#125)
* chore: upgrade Alpine.js version * fix: orange + cool-gray (Tailwind 2) * 0.1.0 * fix semver version detection
1 parent 8ad12a0 commit 4ca1579

5 files changed

Lines changed: 32 additions & 8 deletions

File tree

package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "alpinejs-devtools",
3-
"version": "0.0.10",
3+
"version": "0.1.0",
44
"private": true,
55
"description": "DevTools extension for debugging Alpine.js applications.",
66
"homepage": "https://github.com/alpine-collective/alpinejs-devtools",
@@ -23,7 +23,7 @@
2323
"@rollup/plugin-node-resolve": "^7.1.3",
2424
"@rollup/plugin-replace": "^2.3.4",
2525
"@tailwindcss/forms": "^0.2.1",
26-
"alpinejs": "^2.7.3",
26+
"alpinejs": "^2.8.0",
2727
"cypress": "^6.1.0",
2828
"cypress-iframe": "^1.0.1",
2929
"edge.js": "^1.1.4",

packages/shell-chrome/src/utils.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,11 @@ export function fetchWithTimeout(resource, options) {
1919
* @returns {boolean}
2020
*/
2121
export function isRequiredVersion(required, actual) {
22+
if (required === actual) return true
2223
const requiredArray = required.split('.').map((v) => parseInt(v, 10))
2324
const currentArray = actual.split('.').map((v) => parseInt(v, 10))
2425
for (let i = 0; i < requiredArray.length; i++) {
25-
if (!currentArray[i] || currentArray[i] < requiredArray[i]) {
26+
if (currentArray[i] < requiredArray[i]) {
2627
return false
2728
}
2829
if (currentArray[i] > requiredArray[i]) {

tailwind.config.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
const colors = require('tailwindcss/colors')
2+
13
module.exports = {
24
purge: {
35
content: ['./packages/**/*.{html,edge}', './packages/shell-chrome/src/devtools/devtools.js'],
@@ -17,6 +19,8 @@ module.exports = {
1719
},
1820
extend: {
1921
colors: {
22+
orange: colors.orange,
23+
'cool-gray': colors.coolGray,
2024
alpine: {
2125
100: '#7C87A2',
2226
200: '#616D89',

tests/utils.spec.js

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { createComponentId, getComponentName } from '../packages/shell-chrome/src/utils'
1+
import { isRequiredVersion, getComponentName } from '../packages/shell-chrome/src/utils'
22

33
test('getComponentName > can handle multiple scenarios to determine component name', async () => {
44
window.myFn = () => {}
@@ -24,3 +24,22 @@ test('getComponentName > can handle multiple scenarios to determine component na
2424
element.removeAttribute('role')
2525
expect(getComponentName(element)).toBe('div')
2626
})
27+
28+
describe('isRequiredVersion', () => {
29+
test('works for major', () => {
30+
expect(isRequiredVersion('1.11.0', '2.1.1')).toBe(true)
31+
expect(isRequiredVersion('2.11.0', '0.1.1')).toBe(false)
32+
})
33+
test('works for minor', () => {
34+
expect(isRequiredVersion('1.1.1', '1.11.0')).toBe(true)
35+
expect(isRequiredVersion('1.11.0', '1.1.1')).toBe(false)
36+
})
37+
test('works for patch', () => {
38+
expect(isRequiredVersion('0.11.0', '0.11.1')).toBe(true)
39+
expect(isRequiredVersion('0.1.1', '0.1.0')).toBe(false)
40+
})
41+
test('works for equal', () => {
42+
expect(isRequiredVersion('2.8.0', '2.8.0')).toBe(true)
43+
expect(isRequiredVersion('1.1.0', '1.1.0')).toBe(true)
44+
})
45+
})

0 commit comments

Comments
 (0)