Skip to content

Commit 9f9735b

Browse files
committed
review comment: fix misleading "above center" comment in theta test
Reword the opening comment in atan2_xy_convention_theta_zero_points_up to correctly describe the test point as being at larger Y (image-down direction) rather than "above center", matching the assertion message. #166 (comment)
1 parent 2b948c9 commit 9f9735b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

crates/mujou-export/src/thr.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -358,9 +358,9 @@ mod tests {
358358

359359
#[test]
360360
fn atan2_xy_convention_theta_zero_points_up() {
361-
// atan2(x, y) convention: a point directly above center
362-
// (positive Y in image coords, which is below in screen but
363-
// the ecosystem uses image Y as +Y) has theta = 0.
361+
// atan2(x, y) convention: a point at larger Y (image-down direction)
362+
// relative to center has theta = 0, because atan2(0, +dy) = 0.
363+
// The ecosystem treats +Y (image down) as the theta=0 reference direction.
364364
//
365365
// Point at (100, 200) relative to center (100, 100):
366366
// dx = 0, dy = 100 → atan2(0, 100) = 0.

0 commit comments

Comments
 (0)