fix(dvb): resolve CI lint errors

- Fix rangeValCopy lint errors in delete.go by using index-based iteration
  instead of value copy (avoids copying 192 bytes per iteration)
- Fix gofmt formatting in apply.go and main.go
- Alias sigs.k8s.io/yaml import to k8syaml to avoid package name collision
  with gopkg.in/yaml.v3 used in diff.go

Author: qj0r9j0vc2

cmd/dvb/apply.go

@@ -128,7 +128,7 @@ func applyDevnet(cmd *cobra.Command, devnet *config.YAMLDevnet) (*v1.ApplyDevnet
 // yamlToProtoSpec converts YAML spec to proto DevnetSpec
 func yamlToProtoSpec(yamlSpec *config.YAMLDevnetSpec) *v1.DevnetSpec {
 	spec := &v1.DevnetSpec{
-		Plugin:      yamlSpec.Network,        // YAML uses "network", proto uses "plugin"
+		Plugin:      yamlSpec.Network, // YAML uses "network", proto uses "plugin"
 		NetworkType: yamlSpec.NetworkType,
 		Validators:  int32(yamlSpec.Validators),
 		FullNodes:   int32(yamlSpec.FullNodes),

cmd/dvb/delete.go

@@ -86,8 +86,8 @@ func runDeleteFromFile(cmd *cobra.Command, filePath string, force, dryRun bool)
 	// Preview mode
 	if dryRun {
 		fmt.Printf("Would delete %d devnet(s):\n", len(devnets))
-		for _, d := range devnets {
-			fmt.Printf("  - devnet/%s\n", d.Metadata.Name)
+		for i := range devnets {
+			fmt.Printf("  - devnet/%s\n", devnets[i].Metadata.Name)
 		}
 		fmt.Println("\nRun without --dry-run to delete.")
 		return nil
@@ -96,8 +96,8 @@ func runDeleteFromFile(cmd *cobra.Command, filePath string, force, dryRun bool)
 	// Confirm if not forced
 	if !force {
 		fmt.Printf("This will delete %d devnet(s):\n", len(devnets))
-		for _, d := range devnets {
-			fmt.Printf("  - devnet/%s\n", d.Metadata.Name)
+		for i := range devnets {
+			fmt.Printf("  - devnet/%s\n", devnets[i].Metadata.Name)
 		}
 		fmt.Print("\nAre you sure? [y/N] ")
 		var response string
@@ -114,8 +114,8 @@ func runDeleteFromFile(cmd *cobra.Command, filePath string, force, dryRun bool)
 
 	// Delete each devnet
 	var hasErrors bool
-	for _, d := range devnets {
-		name := d.Metadata.Name
+	for i := range devnets {
+		name := devnets[i].Metadata.Name
 		err := daemonClient.DeleteDevnet(cmd.Context(), name)
 		if err != nil {
 			color.Red("devnet/%s deletion failed: %v", name, err)

cmd/dvb/get.go

@@ -10,7 +10,7 @@ import (
 	v1 "github.com/altuslabsxyz/devnet-builder/api/proto/gen/v1"
 	"github.com/fatih/color"
 	"github.com/spf13/cobra"
-	"sigs.k8s.io/yaml"
+	k8syaml "sigs.k8s.io/yaml"
 )
 
 func newGetCmd() *cobra.Command {
@@ -114,7 +114,7 @@ func listDevnets(cmd *cobra.Command, output, labelSel string) error {
 			if i > 0 {
 				fmt.Println("---")
 			}
-			out, err := yaml.Marshal(protoDevnetToYAML(d))
+			out, err := k8syaml.Marshal(protoDevnetToYAML(d))
 			if err != nil {
 				return fmt.Errorf("failed to marshal yaml: %w", err)
 			}
@@ -172,7 +172,7 @@ func getDevnet(cmd *cobra.Command, name, output string, showNodes bool) error {
 	// Handle yaml/json output
 	switch output {
 	case "yaml":
-		out, err := yaml.Marshal(protoDevnetToYAML(devnet))
+		out, err := k8syaml.Marshal(protoDevnetToYAML(devnet))
 		if err != nil {
 			return fmt.Errorf("failed to marshal yaml: %w", err)
 		}
@@ -322,7 +322,7 @@ func protoDevnetToYAML(d *v1.Devnet) *YAMLDevnetOutput {
 			Annotations: d.Metadata.Annotations,
 		},
 		Spec: YAMLDevnetSpecOutput{
-			Network:        d.Spec.Plugin,     // proto uses Plugin, YAML uses network
+			Network:        d.Spec.Plugin, // proto uses Plugin, YAML uses network
 			NetworkType:    d.Spec.NetworkType,
 			NetworkVersion: d.Spec.SdkVersion, // proto uses SdkVersion, YAML uses networkVersion
 			Validators:     d.Spec.Validators,

cmd/dvb/main.go

@@ -63,7 +63,7 @@ func main() {
 		newGetCmd(),
 		newDeleteCmd(),
 		newDiffCmd(),
-		newDeployCmd(),  // deprecated
+		newDeployCmd(), // deprecated
 		newListCmd(),
 		newStatusCmd(),
 		newStartCmd(),