Merge pull request #175 from alvarorichard/dev

update to 1.8.4

Author: alvarorichard

CHANGELOG.md

@@ -1,46 +1,52 @@
-# GoAnime Release Notes - Version 1.8.3
+# GoAnime Release Notes - Version 1.8.4
 
-Release date: 2026-04-30
+Release date: 2026-05-03
 
 ## Highlights
 
-- **AllAnime Encryption Update**: Updated AllAnime stream decryption from AES-GCM to AES-256-CTR cipher mode to maintain compatibility with their latest API changes.
-- **Zenpen/Kouhen Title Fix**: Fixed critical bug where anime titles with meaningful suffixes (e.g., "Jujutsu Kaisen - Zenpen") were being incorrectly stripped, causing incorrect metadata binding to sibling entries. Now preserves legitimate episode part markers while still removing PT-BR noise.
-- **Distinct ID Tracking**: Added support for keeping MyAnimeList (MAL) and AniList IDs separate throughout the playback pipeline. Previously they were conflated, causing incorrect skip intros and tracking data.
-- **AnimeFire Quality Menu Improvements**: Fixed three UX bugs in the quality picker: items now sort in descending resolution order, duplicate qualities are disambiguated with mirror labels, and pressing Esc now routes back instead of silently playing the first source.
-- **Source Health Diagnostics Enhancement**: Added post-timeout origin probing to distinguish between "client timeout waiting" and "upstream actively down" (Cloudflare 521-524), producing more actionable diagnostic messages.
-- **Cloudflare Challenge Detection Refinement**: Fixed false-positive challenge detection that was blocking legitimate Goyabu episode pages mentioning "cloudflare" in footers/comments/ToS. Now targets specific challenge markers instead of the bare word.
+- **SuperFlix API Migration**: Migrated SuperFlix endpoint from `superflixapi.rest` (deprecated) to `superflixapi.online` (canonical). The legacy host performs a 301 redirect, but Go's HTTP Client downgrades POST to GET, breaking requests. Updated across all code and tests.
+- **SuperFlix Content Filtering**: Implemented episode filtering by air date, removing episodes with missing, "null", or future air dates. This resolves issues where placeholder episodes appeared without available sources.
+- **SuperFlix Error Handling Improvements**: Implemented `ensureJSONResponse()` to detect HTML or non-2xx responses and produce clear error messages instead of cryptic "invalid character '<'". Now performs body-sniffing instead of relying solely on Content-Type header.
+- **Temporarily Disabled Sources**: FlixHQ, SFlix, and 9Anime commented out until fixes are implemented. AnimeDrive also temporarily disabled.
+- **Conditional Logic Refactoring**: Replacement of complex if-else chains with switch statements for improved readability and maintainability across the codebase.
+- **Version Bumped**: Updated to 1.8.4 with automatic normalization of the "v" prefix in CI workflows.
 
 ## Features
 
-- Add regression tests for AllAnime cipher-mode and transport changes.
-- Implement post-timeout origin probing for enhanced source diagnostics (FlixHQ, SFlix, 9Anime).
-- Add support for distinct MAL and AniList IDs in playback and tracking pipeline.
-- Normalize hyphenated search queries in SuperFlix search for better results.
-- Improve AnimeFire quality menu with descending sort, mirror disambiguation, and proper abort handling.
+- Migrate SuperFlix API endpoint to canonical `superflixapi.online` host.
+- Add content filtering for SuperFlix episodes: remove episodes with empty, "null", or future air dates.
+- Implement `ensureJSONResponse()` helper for clear detection of HTTP/HTML errors in SuperFlix APIs.
+- Refactor conditional chains across multiple files: replace nested if-else with switch statements for improved readability.
+- Add support for non-UTC timezones in SuperFlix episode filtering (normalizes to UTC internally).
+- Version normalization: automatic TrimPrefix("v") in CI builds to avoid "vv1.8.4" in outputs.
 
 ## Bug Fixes
 
-- **Critical**: Fix Zenpen/Kouhen title mismatch by preserving meaningful anime title suffixes. CleanTitle now only strips known PT-BR noise patterns, preventing data corruption where "Jujutsu Kaisen: Shimetsu Kaiyuu - Zenpen" was misbound to the Kouhen (Part 2) entry instead of Zenpen (Part 1). This affected Discord RPC, AniSkip, file naming, and tracking.
-- Fix AllAnime cipher-mode decryption: update from AES-GCM to AES-256-CTR to maintain stream extraction compatibility.
-- Fix case-sensitive source matching for AnimeFire ("Animefire.io" vs "AnimeFire") causing source breakdown diagnostics to report zero AnimeFire results despite successful searches.
-- Fix false-positive Cloudflare challenge detection that was blocking legitimate Goyabu episode pages. Relaxed body-text scan from bare "cloudflare" match to specific challenge phrases ("cf-error", "checking your browser", "ray id", etc.) while preserving all real challenge detection.
-- Fix AnimeFire quality selection bug: properly index into sorted sources by user selection instead of matching on rendered labels, fixing silent loss of selection when duplicates exist.
-- Fix AnimeFire quality picker handling of Esc/Ctrl-C to return ErrBackRequested instead of silently playing the first source.
-- Fix dead Blogger token fast-fail by detecting empty batchexecute responses (anti-hijacking prefix only) instead of wasting ~6 seconds on doomed retries.
-- Add nil guard to tracker to prevent crashes on update tracking attempts.
-- Improve Blogger video URL extraction robustness to handle edge cases and malformed responses.
-- Update error messages and log output throughout the codebase for improved clarity and consistency.
+- **Critical**: Fix SuperFlix API host migration: update from `superflixapi.rest` to `superflixapi.online`. The 301 redirect from the legacy host downgrades POST to GET, breaking `/player/bootstrap`. Legacy code received HTML 404 and failed with "invalid character '<' looking for beginning of value".
+- **Critical**: Fix SuperFlix episode filtering: placeholder episodes with `air_date: null` or `air_date: ""` are now removed before returning to the user. Episodes with future air dates are also filtered. This resolves issues where users saw "no servers available" for episodes that haven't yet been released.
+- Fix SuperFlix error messages: implement `ensureJSONResponse()` to detect HTML or non-2xx status codes and produce clear messages instead of "invalid character '<'". Logs now indicate the endpoint, status code, and final URL for diagnosis.
+- Fix SuperFlix air_date timezone handling: filtering now uses UTC internally, preventing leakage of tomorrow's episodes in timezones west of UTC.
+- Temporarily disable FlixHQ, SFlix, and 9Anime source providers until fixes are ready. Sources commented out with `/* */` blocks in provider registry.
+- Temporarily disable AnimeDrive scraper until Cloudflare bypass is implemented.
+- Fix version normalization: strip leading "v" from injected CI version string to avoid "vv1.8.4" in outputs.
+- Refactor logging: replace `log.Fatalln()` with `util.Errorf()` in error handlers of main.go, improving graceful shutdown.
+- Remove Nix configuration files (default.nix, flake.nix, flake.lock, gomod2nix.toml) from repository.
 
 ## Improvements
 
-- Refactor quality menu sorting and labeling logic into buildQualityMenu helper for testability and maintainability.
-- Add comprehensive regression test suites for all major bug fixes (Zenpen/Kouhen, source breakdown, season selection abort, quality menu, Blogger unavailable token, Cloudflare challenges, origin probing).
-- Enhance debug logging throughout Goyabu scraper to aid diagnostics of extraction failures.
-- Add episode page diagnostic dumps (HTML snapshot) when all Goyabu extraction strategies fail in debug mode.
-- Improve download header handling with centralized applyDownloadAuthHeaders function for consistency.
-- Add MarginTop/Priority fields to SuperFlix media results for better UI presentation.
-- Use slices.Sort instead of deprecated sort.Slice in unified scraper manager.
+- Refactor conditional logic: replace if-else chains with switch statements across multiple modules (`allanime_enhanced.go`, `player.go`, `playvideo.go`, `scraper.go`, `download.go`, `appflow/anime_data.go`, `util/util.go`, `util/perf.go`, `scraper/flixhq.go`, `scraper/sflix.go`, `scraper/superflix.go`) for improved readability and maintainability.
+- Add helper function `filterEpisodesByAirDate()` in SuperFlix scraper to centralize episode date filtering logic.
+- Improve SuperFlix error diagnostics: enrich error messages with player URL, content ID, and HTTP status for easier triage.
+- Add `ErrSuperFlixNoServers` typed error to distinguish content-unavailability (placeholder episodes) from system errors.
+- Rename `isFlixHQSourcePlayer()` to `isMovieOrTVSourcePlayer()` in player.go to reflect that both SuperFlix and FlixHQ share the same stream extraction route.
+- Add comprehensive regression test suites:
+  - `runspinner_regression_test.go`: tests for spinner race condition where action completed after runner returned.
+  - `source_routing_regression_test.go`: tests to validate correct routing of SuperFlix and FlixHQ through enhanced API.
+  - `allanime_ctr_regression_test.go`: improvements in slice allocation to avoid inefficient append operations.
+  - `superflix_test.go`: tests for air_date filtering, JSON response validation, HTML error detection, and timezone handling.
+  - `version_regression_test.go`: tests for version string normalization without "v" prefix.
+- Update go.mod/go.sum: dependency bump (klauspost/compress v1.18.5 → v1.18.6).
+- Minor code style improvements: replace `baseURL = baseURL + "/"` with `baseURL += "/"` and `timePerFrame = timePerFrame / 2` with `timePerFrame /= 2`.
 
 ---
 

aur/goanime/PKGBUILD

@@ -1,5 +1,5 @@
 pkgname=goanime
-pkgver=1.8.3
+pkgver=1.8.4
 pkgrel=1
 pkgdesc="A command-line tool to browse, play, and download anime."
 arch=('x86_64')

build/install.iss

@@ -2,7 +2,7 @@
 ; This script is designed to be run from CI with files staged in the build directory
 
 #define MyAppName "GoAnime"
-#define MyAppVersion "1.8.3"
+#define MyAppVersion "1.8.4"
 #define MyAppPublisher "GoAnime Team"
 #define MyAppURL "https://github.com/alvarorichard/GoAnime"
 #define MyAppExeName "goanime.exe"

cmd/goanime/main.go

@@ -2,7 +2,6 @@ package main
 
 import (
 	"fmt"
-	"log"
 	"math"
 	"os"
 	"os/signal"
@@ -77,37 +76,38 @@ func main() {
 		// Check if error is update request
 		if err == util.ErrUpdateRequested {
 			if updateErr := handlers.HandleUpdateRequest(); updateErr != nil {
-				log.Fatalln(util.ErrorHandler(updateErr))
+				util.Errorf("%v", util.ErrorHandler(updateErr))
 			}
 			return
 
 		}
 		// Check if error is download request
 		if err == util.ErrDownloadRequested {
 			if downloadErr := handlers.HandleDownloadRequest(); downloadErr != nil {
-				log.Fatalln(util.ErrorHandler(downloadErr))
+				util.Errorf("%v", util.ErrorHandler(downloadErr))
 			}
 			return
 		}
 		// Check if error is movie download request (FlixHQ/SFlix)
 		if err == util.ErrMovieDownloadRequested {
 			if movieDownloadErr := handlers.HandleMovieDownloadRequest(); movieDownloadErr != nil {
-				log.Fatalln(util.ErrorHandler(movieDownloadErr))
+				util.Errorf("%v", util.ErrorHandler(movieDownloadErr))
 			}
 			return
 		}
 		// Check if error is upscale request
 		if err == util.ErrUpscaleRequested {
 			if upscaleErr := handlers.HandleUpscaleRequest(); upscaleErr != nil {
-				log.Fatalln(util.ErrorHandler(upscaleErr))
+				util.Errorf("%v", util.ErrorHandler(upscaleErr))
 			}
 			return
 		}
 		// For help and version requests, just exit silently
 		if err == util.ErrHelpRequested {
 			return
 		}
-		log.Fatalln(util.ErrorHandler(err))
+		util.Errorf("%v", util.ErrorHandler(err))
+		return
 	}
 
 	// Handle normal playback mode

default.nix

@@ -41,7 +41,7 @@ require (
 	github.com/enetx/http3 v1.0.7 // indirect
 	github.com/enetx/iter v0.0.0-20250912135656-f1583323588f // indirect
 	github.com/go-logfmt/logfmt v0.6.1 // indirect
-	github.com/klauspost/compress v1.18.5 // indirect
+	github.com/klauspost/compress v1.18.6 // indirect
 	github.com/kr/text v0.2.0 // indirect
 	github.com/mitchellh/hashstructure/v2 v2.0.2 // indirect
 	github.com/quic-go/qpack v0.6.0 // indirect

flake.lock

@@ -90,8 +90,8 @@ github.com/google/go-cmp v0.7.0 h1:wk8382ETsv4JYUZwIsn6YpYiWiBsYLSJiTsyBybVuN8=
 github.com/google/go-cmp v0.7.0/go.mod h1:pXiqmnSA92OHEEa9HXL2W4E7lf9JzCmGVUdgjX3N/iU=
 github.com/google/gofuzz v1.2.0 h1:xRy4A+RhZaiKjJ1bPfwQ8sedCA+YS2YcCHW6ec7JMi0=
 github.com/google/gofuzz v1.2.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg=
-github.com/klauspost/compress v1.18.5 h1:/h1gH5Ce+VWNLSWqPzOVn6XBO+vJbCNGvjoaGBFW2IE=
-github.com/klauspost/compress v1.18.5/go.mod h1:cwPg85FWrGar70rWktvGQj8/hthj3wpl0PGDogxkrSQ=
+github.com/klauspost/compress v1.18.6 h1:2jupLlAwFm95+YDR+NwD2MEfFO9d4z4Prjl1XXDjuao=
+github.com/klauspost/compress v1.18.6/go.mod h1:cwPg85FWrGar70rWktvGQj8/hthj3wpl0PGDogxkrSQ=
 github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE=
 github.com/kr/pretty v0.3.1/go.mod h1:hoEshYVHaxMs3cyo3Yncou5ZscifuDolrwPKZanG3xk=
 github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=