fix(codacy): address BestPractice, Documentation and CodeStyle issues

- Remove superfluous else blocks in util.go by restructuring if-return chains
- Add proper doc comments for all exported vars in util package
- Add missing package comments for streaming/benchmark_test and updater
- Rename unused mock parameters to _ in discord, providers test files
- Fix zero-value initializer in perf.go (var c int64 = 0 → var c int64)
- Fix export comment formats in tmdb.go, discord.go, anime.go, api.go

Author: Vittuu

internal/api/anime.go

@@ -164,6 +164,7 @@ func enrichAnimeData(anime *models.Anime) error {
 	return nil
 }
 
+// ParseAnimes extracts a list of anime entries from a GoAnime search results page.
 func ParseAnimes(doc *goquery.Document) []models.Anime {
 	var animes []models.Anime
 
@@ -180,6 +181,7 @@ func ParseAnimes(doc *goquery.Document) []models.Anime {
 	return animes
 }
 
+// FetchAnimeFromAniList queries the AniList GraphQL API by anime name.
 func FetchAnimeFromAniList(animeName string) (*models.AniListResponse, error) {
 	return FetchAnimeFromAniListWithURL(animeName, "")
 }
@@ -345,6 +347,7 @@ func generateSearchVariations(cleanedName string) []string {
 	return variations
 }
 
+// CleanTitle removes common suffixes, tags, and source annotations from an anime title.
 func CleanTitle(title string) string {
 	cleaned := title
 

internal/api/api.go

@@ -129,11 +129,11 @@ func SafeTransport(timeout time.Duration) *http.Transport {
 
 	return &http.Transport{
 		// Custom dial function for regular (non-TLS) connections.
-		DialContext: func(ctx context.Context, network, addr string) (net.Conn, error) {
+		DialContext: func(_ context.Context, network, addr string) (net.Conn, error) {
 			return dialFunc(network, addr, timeout, nil)
 		},
 		// Custom dial function for TLS connections, using the specified TLS configuration.
-		DialTLSContext: func(ctx context.Context, network, addr string) (net.Conn, error) {
+		DialTLSContext: func(_ context.Context, network, addr string) (net.Conn, error) {
 			return dialFunc(network, addr, timeout, tlsConfig)
 		},
 		// Set the timeout for the TLS handshake process.

internal/api/movie/tmdb.go

@@ -16,9 +16,9 @@ import (
 )
 
 const (
-	// TMDB API base URL
+	// TMDBBaseURL is the TMDB REST API base URL.
 	TMDBBaseURL = "https://api.themoviedb.org/3"
-	// TMDB image base URL
+	// TMDBImageBaseURL is the TMDB image CDN base URL.
 	TMDBImageBaseURL = "https://image.tmdb.org/t/p"
 )
 

internal/api/providers/goyabu_test.go

@@ -57,7 +57,7 @@ type mockUnifiedScraper struct {
 	streamArg   string
 }
 
-func (m *mockUnifiedScraper) SearchAnime(query string, options ...any) ([]*models.Anime, error) {
+func (m *mockUnifiedScraper) SearchAnime(_ string, _ ...any) ([]*models.Anime, error) {
 	return nil, nil
 }
 
@@ -66,7 +66,7 @@ func (m *mockUnifiedScraper) GetAnimeEpisodes(animeURL string) ([]models.Episode
 	return m.episodes, nil
 }
 
-func (m *mockUnifiedScraper) GetStreamURL(episodeURL string, options ...any) (string, map[string]string, error) {
+func (m *mockUnifiedScraper) GetStreamURL(episodeURL string, _ ...any) (string, map[string]string, error) {
 	m.streamArg = episodeURL
 	if m.streamCalls < len(m.streamErrs) {
 		err := m.streamErrs[m.streamCalls]

internal/api/providers/nineanime_test.go

@@ -20,7 +20,7 @@ type nineAnimeMockScraper struct {
 	streamArg   string
 }
 
-func (m *nineAnimeMockScraper) SearchAnime(query string, options ...any) ([]*models.Anime, error) {
+func (m *nineAnimeMockScraper) SearchAnime(_ string, _ ...any) ([]*models.Anime, error) {
 	return nil, nil
 }
 
@@ -29,7 +29,7 @@ func (m *nineAnimeMockScraper) GetAnimeEpisodes(animeURL string) ([]models.Episo
 	return m.episodes, nil
 }
 
-func (m *nineAnimeMockScraper) GetStreamURL(episodeURL string, options ...any) (string, map[string]string, error) {
+func (m *nineAnimeMockScraper) GetStreamURL(episodeURL string, _ ...any) (string, map[string]string, error) {
 	m.streamArg = episodeURL
 	if m.streamErr != nil {
 		return "", nil, m.streamErr

internal/api/providers/registry_test.go

@@ -23,7 +23,7 @@ func (p *testProvider) FetchEpisodes(_ context.Context, anime *models.Anime) ([]
 	return anime.Episodes, nil
 }
 
-func (p *testProvider) FetchStreamURL(_ context.Context, episode *models.Episode, anime *models.Anime, quality string) (string, error) {
+func (p *testProvider) FetchStreamURL(_ context.Context, _ *models.Episode, _ *models.Anime, quality string) (string, error) {
 	return quality, nil
 }
 
@@ -32,7 +32,7 @@ func TestForKindCachesProviderInstances(t *testing.T) {
 
 	kind := source.SourceKind("TestCacheProvider")
 	var calls atomic.Int32
-	RegisterProvider(kind, func(sm *scraper.ScraperManager) Provider {
+	RegisterProvider(kind, func(_ *scraper.ScraperManager) Provider {
 		calls.Add(1)
 		return &testProvider{kind: kind}
 	})
@@ -60,7 +60,7 @@ func TestForKindConcurrentFactoryCall(t *testing.T) {
 
 	kind := source.SourceKind("TestConcurrentProvider")
 	var calls atomic.Int32
-	RegisterProvider(kind, func(sm *scraper.ScraperManager) Provider {
+	RegisterProvider(kind, func(_ *scraper.ScraperManager) Provider {
 		calls.Add(1)
 		return &testProvider{kind: kind}
 	})
@@ -196,7 +196,7 @@ func TestForKindAndRegisterProviderConcurrentSafe(t *testing.T) {
 	done := make(chan struct{})
 	go func() {
 		defer close(done)
-		RegisterProvider(kind, func(sm *scraper.ScraperManager) Provider {
+		RegisterProvider(kind, func(_ *scraper.ScraperManager) Provider {
 			calls.Add(1)
 			return &testProvider{kind: kind}
 		})

internal/discord/discord.go

@@ -1,3 +1,4 @@
+// Package discord manages Discord Rich Presence integration for GoAnime playback sessions.
 package discord
 
 import (

internal/discord/test/discord_test.go

@@ -19,7 +19,7 @@ type MockMPVClient struct {
 
 // MockMPVSendCommand é uma implementação mock de mpvSendCommand
 // mockMPVSendCommand é uma função mock simples
-func mockMPVSendCommand(socketPath string, args []any) (any, error) {
+func mockMPVSendCommand(_ string, args []any) (any, error) {
 	// Simula a resposta do MPV para time-pos
 	if len(args) >= 2 && args[0] == "get_property" && args[1] == "time-pos" {
 		return 630.0, nil // 10 minutos e 30 segundos em segundos
@@ -90,7 +90,7 @@ func TestGetCurrentPlaybackPosition(t *testing.T) {
 
 	t.Run("Should handle MPV send command error", func(t *testing.T) {
 		// Arrange
-		errorMockFunc := func(socketPath string, args []any) (any, error) {
+		errorMockFunc := func(_ string, _ []any) (any, error) {
 			return nil, fmt.Errorf("connection failed")
 		}
 
@@ -244,7 +244,7 @@ func TestRichPresenceIntegration(t *testing.T) {
 func TestFetchDuration(t *testing.T) {
 	t.Run("Should fetch duration successfully", func(t *testing.T) {
 		// Arrange
-		mockFunc := func(socketPath string, args []any) (any, error) {
+		mockFunc := func(_ string, args []any) (any, error) {
 			if len(args) >= 2 && args[0] == "get_property" && args[1] == "duration" {
 				return 1440.0, nil // 24 minutes in seconds
 			}
@@ -281,7 +281,7 @@ func TestFetchDuration(t *testing.T) {
 
 	t.Run("Should handle MPV error gracefully", func(t *testing.T) {
 		// Arrange
-		errorMockFunc := func(socketPath string, args []any) (any, error) {
+		errorMockFunc := func(_ string, _ []any) (any, error) {
 			return nil, fmt.Errorf("connection failed")
 		}
 
@@ -302,7 +302,7 @@ func TestFetchDuration(t *testing.T) {
 
 		// Variable to capture the callback result
 		var callbackCalled bool
-		callback := func(durSec int) {
+		callback := func(_ int) {
 			callbackCalled = true
 		}
 
@@ -315,7 +315,7 @@ func TestFetchDuration(t *testing.T) {
 
 	t.Run("Should handle nil duration response", func(t *testing.T) {
 		// Arrange
-		nilMockFunc := func(socketPath string, args []any) (any, error) {
+		nilMockFunc := func(_ string, _ []any) (any, error) {
 			return nil, nil // Simulate nil response
 		}
 
@@ -336,7 +336,7 @@ func TestFetchDuration(t *testing.T) {
 
 		// Variable to capture the callback result
 		var callbackCalled bool
-		callback := func(durSec int) {
+		callback := func(_ int) {
 			callbackCalled = true
 		}
 
@@ -349,7 +349,7 @@ func TestFetchDuration(t *testing.T) {
 
 	t.Run("Should use instance socket path when parameter is empty", func(t *testing.T) {
 		// Arrange
-		mockFunc := func(socketPath string, args []any) (any, error) {
+		mockFunc := func(_ string, args []any) (any, error) {
 			if len(args) >= 2 && args[0] == "get_property" && args[1] == "duration" {
 				return 600.0, nil // 10 minutes in seconds
 			}

internal/discord/test/superflix_discord_test.go

@@ -19,7 +19,7 @@ import (
 
 // mockMPVFullState provides a complete mock MPV that returns all properties
 // needed by getPrecisePlaybackState and updateDiscordPresence
-func mockMPVFullState(socketPath string, args []any) (any, error) {
+func mockMPVFullState(_ string, args []any) (any, error) {
 	if len(args) >= 2 && args[0] == "get_property" {
 		switch args[1] {
 		case "time-pos":

internal/streaming/benchmark_test.go

@@ -1,3 +1,4 @@
+// Package streaming provides URL classification and download strategy helpers.
 package streaming
 
 import "testing"