refactor: update golangci-lint action to v9 and adjust theme pointer usage in shell and anime results

Author: alvarorichard

.github/workflows/ci.yml

@@ -71,7 +71,7 @@ jobs:
         run: go mod download
 
       - name: Run golangci-lint
-        uses: golangci/golangci-lint-action@v8
+        uses: golangci/golangci-lint-action@v9
         with:
           version: latest
 

.github/workflows/release.yml

@@ -40,7 +40,7 @@ jobs:
           go mod download
 
       - name: Run linter
-        uses: golangci/golangci-lint-action@v8
+        uses: golangci/golangci-lint-action@v9
         with:
           version: latest
 
@@ -622,4 +622,4 @@ jobs:
           echo "" >> $GITHUB_STEP_SUMMARY
           echo "- Package: goanime" >> $GITHUB_STEP_SUMMARY
           echo "- Version: ${{ steps.version.outputs.VERSION_NUMBER }}" >> $GITHUB_STEP_SUMMARY
-          echo "- AUR URL: https://aur.archlinux.org/packages/goanime" >> $GITHUB_STEP_SUMMARY
+          echo "- AUR URL: https://aur.archlinux.org/packages/goanime" >> $GITHUB_STEP_SUMMARY

internal/tui/anime_results.go

@@ -96,7 +96,7 @@ type animeResultsModel struct {
 // newAnimeResultsModel creates the styled, filterable anime result screen.
 func newAnimeResultsModel(animes []*models.Anime) *animeResultsModel {
 	theme := NewTheme(true)
-	shell := NewShell(theme, "Search > Results")
+	shell := NewShell(&theme, "Search > Results")
 	items := make([]list.Item, 0, len(animes))
 	for _, anime := range animes {
 		if anime == nil {
@@ -222,7 +222,7 @@ func (m *animeResultsModel) View() tea.View {
 				quality = value
 			}
 		}
-		details := renderAnimeDetails(m.theme, name, source, year, mediaType, quality)
+		details := renderAnimeDetails(&m.theme, name, source, year, mediaType, quality)
 		frameWidth, frameHeight := m.theme.Panel.GetFrameSize()
 		panel := m.theme.Panel.
 			Width(max(panelWidth-frameWidth, 1)).
@@ -239,7 +239,7 @@ func (m *animeResultsModel) View() tea.View {
 }
 
 // renderAnimeDetails composes styled lines without JoinVertical's unstyled padding.
-func renderAnimeDetails(theme Theme, name, source, year, mediaType, quality string) string {
+func renderAnimeDetails(theme *Theme, name, source, year, mediaType, quality string) string {
 	return strings.Join([]string{
 		theme.Primary.Render("Details"),
 		"",

internal/tui/anime_results_test.go

@@ -284,7 +284,7 @@ func TestRenderAnimeDetails(t *testing.T) {
 	t.Parallel()
 
 	theme := NewTheme(true)
-	details := renderAnimeDetails(theme, "The Boys", "SuperFlix", "2019", "tv", "—")
+	details := renderAnimeDetails(&theme, "The Boys", "SuperFlix", "2019", "tv", "—")
 
 	assert.Contains(t, details, "Details")
 	assert.Contains(t, details, "The Boys")

internal/tui/program_test.go

@@ -11,7 +11,7 @@ import (
 // minimalModel is the simplest possible Bubble Tea model for construction tests.
 type minimalModel struct{}
 
-func (m minimalModel) Init() tea.Cmd                        { return nil }
+func (m minimalModel) Init() tea.Cmd                       { return nil }
 func (m minimalModel) Update(tea.Msg) (tea.Model, tea.Cmd) { return m, nil }
 func (m minimalModel) View() tea.View                      { return tea.NewView("") }
 

internal/tui/shell.go

@@ -22,9 +22,9 @@ type Shell struct {
 }
 
 // NewShell creates a shell with safe dimensions before the first resize event.
-func NewShell(theme Theme, breadcrumb string) Shell {
+func NewShell(theme *Theme, breadcrumb string) Shell {
 	return Shell{
-		Theme:      theme,
+		Theme:      *theme,
 		Breadcrumb: breadcrumb,
 		Width:      defaultShellWidth,
 		Height:     defaultShellHeight,
@@ -38,7 +38,7 @@ func (s *Shell) Resize(width, height int) {
 }
 
 // ContentSize returns space left after header, separators, and footer.
-func (s Shell) ContentSize() (int, int) {
+func (s *Shell) ContentSize() (int, int) {
 	width := s.Width
 	if width <= 0 {
 		width = defaultShellWidth
@@ -51,7 +51,7 @@ func (s Shell) ContentSize() (int, int) {
 }
 
 // Render wraps body content in responsive navigation chrome.
-func (s Shell) Render(body, footer string) string {
+func (s *Shell) Render(body, footer string) string {
 	width, height := s.ContentSize()
 	header := s.Theme.Header.Render("GOANIME")
 	if width >= 34 && s.Breadcrumb != "" {

internal/tui/shell_test.go

@@ -8,10 +8,16 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
+// newTestShell builds a shell over an addressable test theme.
+func newTestShell(breadcrumb string) Shell {
+	theme := NewTheme(true)
+	return NewShell(&theme, breadcrumb)
+}
+
 func TestNewShell(t *testing.T) {
 	t.Parallel()
 
-	shell := NewShell(NewTheme(true), "Search > Results")
+	shell := newTestShell("Search > Results")
 
 	assert.Equal(t, defaultShellWidth, shell.Width)
 	assert.Equal(t, defaultShellHeight, shell.Height)
@@ -34,7 +40,7 @@ func TestShellResize(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
-			shell := NewShell(NewTheme(true), "")
+			shell := newTestShell("")
 			shell.Resize(tt.width, tt.height)
 			assert.Equal(t, tt.wantWidth, shell.Width)
 			assert.Equal(t, tt.wantHeight, shell.Height)
@@ -121,7 +127,7 @@ func TestShellRender(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
-			shell := NewShell(NewTheme(true), "Search > Results")
+			shell := newTestShell("Search > Results")
 			shell.Resize(tt.width, 24)
 
 			got := shell.Render("BODY", "↑↓ navigate  / filter")
@@ -141,7 +147,7 @@ func TestShellRender(t *testing.T) {
 			width  int
 			height int
 		}{{1, 5}, {8, 5}, {20, 6}, {33, 8}, {80, 12}} {
-			shell := NewShell(NewTheme(true), strings.Repeat("long breadcrumb ", 20))
+			shell := newTestShell(strings.Repeat("long breadcrumb ", 20))
 			shell.Resize(size.width, size.height)
 			body := strings.Repeat("very long body ", 20) + "\n" + strings.Repeat("extra line\n", 20)