Skip to content

Commit 756eccd

Browse files
🧹 [code health improvement] Replace empty catch blocks with logging in WebViewLoginScreen.kt
Co-authored-by: alvin000009238 <107313913+alvin000009238@users.noreply.github.com>
1 parent fd03a1f commit 756eccd

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

android/app/src/main/java/com/clhs/score/ui/WebViewLoginScreen.kt

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -322,13 +322,17 @@ private val LOGIN_HOOK_JS = """
322322
try {
323323
var loginField = document.querySelector('input[name="LoginId"]');
324324
if (loginField) loginId = loginField.value || '';
325-
} catch(e) {}
325+
} catch(e) {
326+
console.error('Error reading LoginId field:', e);
327+
}
326328
327329
if (!loginId && body) {
328330
try {
329331
var params = new URLSearchParams(body);
330332
loginId = params.get('LoginId') || '';
331-
} catch(e) {}
333+
} catch(e) {
334+
console.error('Error parsing body for LoginId:', e);
335+
}
332336
}
333337
334338
self.addEventListener('load', function() {
@@ -339,7 +343,9 @@ private val LOGIN_HOOK_JS = """
339343
window.AndroidLogin.onLoginSuccess(loginId);
340344
}
341345
}
342-
} catch(e) {}
346+
} catch(e) {
347+
console.error('Error parsing login response:', e);
348+
}
343349
});
344350
}
345351
return origSend.apply(this, arguments);

0 commit comments

Comments
 (0)