fix(PR#89): address review comments

- TmuxSessionManager: call startPolling() for fallback reliability
- Remove redundant assignments before completeTask() in cancel()
- Remove unused model parameter from LaunchOptions
- Remove unused POLL_INTERVAL_BACKGROUND_MS import
- Remove unused createSessionCreatedHandler/createSessionStatusHandler methods
- Fix misplaced comment in schema.ts

Author: “nghyane”

src/background/background-manager.ts

@@ -15,7 +15,6 @@
 
 import type { PluginInput } from '@opencode-ai/plugin';
 import type { BackgroundTaskConfig, PluginConfig } from '../config';
-import { POLL_INTERVAL_BACKGROUND_MS } from '../config';
 import type { TmuxConfig } from '../config/schema';
 import { applyAgentVariant, resolveAgentVariant } from '../utils';
 import { log } from '../utils/logger';
@@ -66,7 +65,6 @@ export interface LaunchOptions {
   prompt: string; // Initial prompt to send to the agent
   description: string; // Human-readable task description
   parentSessionId: string; // Parent session ID for task hierarchy
-  model?: string; // Optional model override
   notifyOnComplete?: boolean; // Whether to notify parent session on completion
 }
 
@@ -225,10 +223,9 @@ export class BackgroundTaskManager {
         sessionId: session.data.id,
       });
     } catch (error) {
-      task.status = 'failed';
-      task.error = error instanceof Error ? error.message : String(error);
-      task.completedAt = new Date();
-      this.completeTask(task, 'failed', task.error);
+      const errorMessage =
+        error instanceof Error ? error.message : String(error);
+      this.completeTask(task, 'failed', errorMessage);
     } finally {
       this.activeStarts--;
       this.processQueue();
@@ -435,9 +432,6 @@ export class BackgroundTaskManager {
           }
         }
 
-        task.status = 'cancelled';
-        task.error = 'Cancelled by user';
-        task.completedAt = new Date();
         this.completeTask(task, 'cancelled', 'Cancelled by user');
         return 1;
       }
@@ -459,9 +453,6 @@ export class BackgroundTaskManager {
           }
         }
 
-        task.status = 'cancelled';
-        task.error = 'Cancelled by user';
-        task.completedAt = new Date();
         this.completeTask(task, 'cancelled', 'Cancelled by user');
         count++;
       }

src/background/tmux-session-manager.ts

@@ -116,6 +116,9 @@ export class TmuxSessionManager {
         sessionId,
         paneId: paneResult.paneId,
       });
+
+      // Start polling for fallback reliability
+      this.startPolling();
     }
   }
 
@@ -226,28 +229,6 @@ export class TmuxSessionManager {
     }
   }
 
-  /**
-   * Create the event handler for session.created events.
-   */
-  createSessionCreatedHandler(): (input: {
-    event: SessionEvent;
-  }) => Promise<void> {
-    return async (input) => {
-      await this.onSessionCreated(input.event);
-    };
-  }
-
-  /**
-   * Create the event handler for session.status events.
-   */
-  createSessionStatusHandler(): (input: {
-    event: SessionEvent;
-  }) => Promise<void> {
-    return async (input) => {
-      await this.onSessionStatus(input.event);
-    };
-  }
-
   /**
    * Clean up all tracked sessions.
    */

src/config/schema.ts

@@ -39,7 +39,6 @@ export type Preset = z.infer<typeof PresetSchema>;
 export const McpNameSchema = z.enum(['websearch', 'context7', 'grep_app']);
 export type McpName = z.infer<typeof McpNameSchema>;
 
-// Main plugin config
 // Background task configuration
 export const BackgroundTaskConfigSchema = z.object({
   notifyOnComplete: z.boolean().default(false),
@@ -48,6 +47,7 @@ export const BackgroundTaskConfigSchema = z.object({
 
 export type BackgroundTaskConfig = z.infer<typeof BackgroundTaskConfigSchema>;
 
+// Main plugin config
 export const PluginConfigSchema = z.object({
   preset: z.string().optional(),
   presets: z.record(z.string(), PresetSchema).optional(),