Skip to content

Commit bffaa44

Browse files
authored
Settings: Better Defaults (#1650)
* Settings: Increase saturation multiplier Reason: Because of inaccuracies of the network latency estimation algorithm which cause it to be more conservative * Settings: Be more generous with FR Reason: at the default values shimmering at the edges these values make it much least noticeable and still very functional for users with low-end hardware(people with higher end hardware can always just increase it if they want no shimmer * Settings: Update saturation and change schema settings Reason: Last value causes frames to get bunched up and it doesn't make sense to have one setting have a step size of 0.05
1 parent bb559d1 commit bffaa44

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

alvr/session/src/settings.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ pub enum BitrateMode {
247247
help = "Percentage of network bandwidth to allocate for video transmission"
248248
))]
249249
#[schema(flag = "real-time")]
250-
#[schema(gui(slider(min = 0.5, max = 2.0, step = 0.05)))]
250+
#[schema(gui(slider(min = 0.5, max = 5.0, step = 0.01)))]
251251
saturation_multiplier: f32,
252252

253253
#[schema(strings(display_name = "Maximum bitrate"))]
@@ -916,7 +916,7 @@ pub fn session_settings_default() -> SettingsDefault {
916916
mode: BitrateModeDefault {
917917
ConstantMbps: 30,
918918
Adaptive: BitrateModeAdaptiveDefault {
919-
saturation_multiplier: 0.95,
919+
saturation_multiplier: 1.0,
920920
max_bitrate_mbps: SwitchDefault {
921921
enabled: false,
922922
content: 100,
@@ -1030,8 +1030,8 @@ pub fn session_settings_default() -> SettingsDefault {
10301030
foveated_rendering: SwitchDefault {
10311031
enabled: true,
10321032
content: FoveatedRenderingDescDefault {
1033-
center_size_x: 0.4,
1034-
center_size_y: 0.35,
1033+
center_size_x: 0.45,
1034+
center_size_y: 0.4,
10351035
center_shift_x: 0.4,
10361036
center_shift_y: 0.1,
10371037
edge_ratio_x: 4.,

0 commit comments

Comments
 (0)