refactor(server_core): 🚨 Fix lints and fail CI on clippy warnings

Author: zmerp

alvr/graphics/src/stream.rs

@@ -224,6 +224,8 @@ impl StreamRenderer {
         }
     }
 
+    /// # Safety
+    /// `hardware_buffer` must be a valid pointer to a ANativeWindowBuffer.
     pub unsafe fn render(&self, hardware_buffer: *mut c_void, view_params: [StreamViewParams; 2]) {
         // if hardware_buffer is available copy stream to staging texture
         if !hardware_buffer.is_null() {

alvr/server_core/src/connection.rs

@@ -312,8 +312,9 @@ pub fn handshake_loop(ctx: Arc<ConnectionContext>, lifecycle_state: Arc<RwLock<L
                 }
             };
 
-            if let WiredConnectionStatus::NotReady(m) = status {
-                dbg_connection!("handshake_loop: Wired connection not ready: {m}");
+            #[cfg_attr(not(debug_assertions), allow(unused_variables))]
+            if let WiredConnectionStatus::NotReady(s) = status {
+                dbg_connection!("handshake_loop: Wired connection not ready: {s}");
                 thread::sleep(RETRY_CONNECT_MIN_INTERVAL);
                 continue;
             }

alvr/xtask/src/ci.rs

@@ -44,16 +44,20 @@ pub fn clippy_ci() {
     let stream = Deserializer::from_slice(&out.stdout).into_iter::<Value>();
 
     // https://doc.rust-lang.org/cargo/reference/external-tools.html#json-messages
-    for message in stream.filter_map(|msg| {
-        let msg = msg.unwrap();
+    let messages = stream
+        .filter_map(|msg| {
+            let msg = msg.unwrap();
 
-        if msg.get("reason")? == "compiler-message" {
-            msg.get("message").map(|x| x.to_owned())
-        } else {
-            None
-        }
-    }) {
-        let msg: CompilerMessage = json::from_value(message).unwrap();
+            if msg.get("reason")? == "compiler-message" {
+                msg.get("message").map(|x| x.to_owned())
+            } else {
+                None
+            }
+        })
+        .collect::<Vec<_>>();
+
+    for message in &messages {
+        let msg: CompilerMessage = json::from_value(message.clone()).unwrap();
 
         if msg.message_type != "diagnostic" {
             continue;
@@ -100,4 +104,8 @@ pub fn clippy_ci() {
     if !out.status.success() {
         panic!("ci clippy didn't exit with 0 code, propagating failure");
     }
+
+    if !messages.is_empty() {
+        panic!("ci clippy produced warnings");
+    }
 }