Skip to content

Commit 301a3eb

Browse files
fix: set custom invoice number only if available (#228) (#231)
The custom invoice number might not be generated until submission. For einvoice validation to pass during previous draft saves, we need to fall back to doc.name as long as the custom number is not available. (cherry picked from commit 7f79976) Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
1 parent f975065 commit 301a3eb

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

eu_einvoice/european_e_invoice/custom/sales_invoice.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -213,12 +213,11 @@ def _set_header(self):
213213
sales_invoice_number_field = frappe.db.get_single_value(
214214
"E Invoice Settings", "sales_invoice_number_field"
215215
)
216-
if sales_invoice_number_field:
217-
invoice_name = self.invoice.get(sales_invoice_number_field)
218-
else:
219-
invoice_name = self.invoice.name
220216

221-
self.doc.header.id = invoice_name
217+
if sales_invoice_number_field and (invoice_number := self.invoice.get(sales_invoice_number_field)):
218+
self.doc.header.id = invoice_number
219+
else:
220+
self.doc.header.id = self.invoice.name
222221

223222
# https://unece.org/fileadmin/DAM/trade/untdid/d16b/tred/tred1001.htm
224223
if self.invoice.is_return:

0 commit comments

Comments
 (0)