Skip to content

LEX fix#1187

Open
orimay wants to merge 3 commits into
amark:masterfrom
orimay:patch-2
Open

LEX fix#1187
orimay wants to merge 3 commits into
amark:masterfrom
orimay:patch-2

Conversation

@orimay

@orimay orimay commented Jan 12, 2022

Copy link
Copy Markdown
Contributor

This way, we take order into account even if we have the wildcard match

@amark

amark commented Feb 3, 2022

Copy link
Copy Markdown
Owner

@orimay wow! You're one of the few people who has been able to SUBTRACT lines of code. That's like gold star 🌟 status right there. I'm very impressed, I need to find time this/next week now that I'm back to do a call with you, hopefully I'll run some other checks/tests before then too, but... I'm bad at overpromising. I'm very excited about this.

@amark

amark commented Feb 19, 2022

Copy link
Copy Markdown
Owner

No rush, like we talked, still looking to merge this after the couple tweaks. No rush tho, I appreciate the help.

@amark

amark commented Feb 19, 2022

Copy link
Copy Markdown
Owner

Oh oops! I should have looked at your other PR before commenting here. Now I feel stupid/dumb. So sorry.

IDK why but GitHub not update me, so please ping me! (which... I know I have a telegram message, so you probably did, so I need to log onto telegram to check that too. Sorry I'm so bad/slow!)

@orimay

orimay commented Feb 19, 2022

Copy link
Copy Markdown
Contributor Author

No worries!

@orimay

orimay commented Feb 19, 2022

Copy link
Copy Markdown
Contributor Author

I thought I pushed the update.. Will try to look into this as I get access to my laptop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants