Skip to content

Commit b866d91

Browse files
Added more detailed logging.
1 parent cb70e5f commit b866d91

File tree

4 files changed

+13
-4
lines changed

4 files changed

+13
-4
lines changed

src/fmcore/framework/_chain/Chain.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -291,8 +291,8 @@ def run(
291291
background: bool = False,
292292
tracker: Optional[Union[Tracker, Dict, str]] = None,
293293
notifier: Optional[Union[Notifier, Dict, str]] = None,
294-
store_step_inputs: bool = False,
295-
store_step_outputs: bool = False,
294+
store_step_inputs: bool = True,
295+
store_step_outputs: bool = True,
296296
after: Optional[ChainExecution] = None,
297297
after_wait: conint(ge=0) = 15,
298298
step_wait: confloat(ge=0.0) = 0.0,

src/fmcore/framework/_dataset.py

+4
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,10 @@ def concat(
8585
@model_validator(mode="before")
8686
@classmethod
8787
def _set_dataset_params(cls, params: Dict) -> Dict:
88+
if "data_schema" not in params:
89+
raise ValueError(
90+
f"Cannot create instance of class '{cls.class_name}' without passing `data_schema` parameter."
91+
)
8892
data_schema: Union[Schema, MLTypeSchema] = params["data_schema"]
8993
if isinstance(data_schema, dict):
9094
## We need to infer the schema:

src/fmcore/framework/_predictions.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@
3636
MLTypeSchema,
3737
TaskOrStr,
3838
)
39-
from fmcore.framework._task_mixins import InputOutputDataMixin, SchemaValidationError
4039
from fmcore.framework._dataset import Dataset
40+
from fmcore.framework._task_mixins import InputOutputDataMixin, SchemaValidationError
4141

4242
Predictions = "Predictions"
4343
Visualization = "Visualization"
@@ -69,6 +69,11 @@ def _pre_registration_hook(cls):
6969
@model_validator(mode="before")
7070
@classmethod
7171
def _set_predictions_params(cls, params: Dict) -> Dict:
72+
if "data_schema" not in params:
73+
raise ValueError(
74+
f"Cannot create instance of class '{cls.class_name}' without passing `data_schema` parameter."
75+
)
76+
7277
params["data_schema"]: Schema = Schema.of(params["data_schema"], schema_template=cls.schema_template)
7378
# data_schema: Union[Schema, MLTypeSchema] = params['data_schema']
7479
# if isinstance(data_schema, dict):

src/fmcore/framework/_task/text_generation.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -757,7 +757,7 @@ class LanguageModelTaskMixin(Algorithm, ABC):
757757
icl_sampler: Optional[ICLSampler] = None ## Will be not-None when icl_dataset is not-None.
758758

759759
class Hyperparameters(Algorithm.Hyperparameters):
760-
lm: Optional[Dict] ## Params for llm
760+
lm: Optional[Dict] = None ## Params for llm
761761
batch_size: Optional[conint(ge=1)] = 1 ## By default, predict 1 row at a time.
762762
prompt_template: constr(min_length=1)
763763
icl_template: Optional[constr(min_length=1)] = None

0 commit comments

Comments
 (0)