Postman tests running against localhost only and not Netlify preview deploy

[ivelin]

Describe the bug
CI flow has a bug. It waits for netlify preview deployment, but does not use it for test run.

ambianic-subscriptions/.github/workflows/ci.yml

Line 34 in 3d9c15b

- name: Wait for successful preview deployment

      - name: Wait for successful preview deployment
        if: ${{ github.event_name == 'pull_request' }}
        uses: jakepartusch/wait-for-netlify-action@v1
        id: get-netlify-url
        with:
          site_name: "ambianic-serverless"
          max_timeout: 60

      - name: Run tests against deployed preview
        if: ${{ github.event_name == 'pull_request' }}
        run:  npm run test:postman
        env:
          FUNCTION_URL: http://127.0.0.1:4010

Expected behavior
Inspect closely the ambianc-ui flow to understand how netlify wait assigns an environment variable which is then passed on to the test step.

ambianic-subscriptions/.github/workflows/ci.yml

Line 46 in 3d9c15b

FUNCTION_URL: http://127.0.0.1:4010

[vickywane]

@ivelin i would have to rename and adjust that CI job to run tests locally.

Like we discussed earlier, the tests are making use of the Mock HTTP server provided by Prism and the FUNCTION_URL variable is the endpoint for the test server.

Since the wait-for-netlify-action also ensures that a preview deployment was made successfully on Netlify, i thought it good to keep the action within the workflow. Asides that, the deployed preview is not being used by other steps within the workflow.

[ivelin]

@vickywane testing locally is one step. Testing against preview deploy is a separate step. Both have value.
Currently wait-for-netlify is sitting on its own, but is not used in a follow up test step against the preview deployment.
See again the ambianic-ui lighthouse flow and add the necessary test step to verify the API against the netlify preview deployment using the URL variable provided by wait-for-netlify.