Skip to content

Commit 742764c

Browse files
erwei-xilinxclaude
andcommitted
Address PR review: use CRITICAL default level and error/exception for failures
- Default log level → CRITICAL per reviewer request (suppress all non-critical) - xrt-smi CalledProcessError → logger.error (was warning) - Unexpected Exception → logger.exception (includes traceback) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent c3712fa commit 742764c

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

amd_triton_npu/backend/driver.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
import air.passmanager
2626

2727
logger = logging.getLogger(__name__)
28-
logger.setLevel(logging.WARNING)
28+
logger.setLevel(logging.CRITICAL)
2929
if os.getenv("AMD_TRITON_NPU_DEBUG", "0") == "1":
3030
logger.setLevel(logging.DEBUG)
3131
if not logger.handlers:
@@ -187,10 +187,10 @@ def get_npu_device_info():
187187
return devices
188188

189189
except subprocess.CalledProcessError as e:
190-
logger.warning("Failed to run xrt-smi: %s", e.stderr)
190+
logger.error("Failed to run xrt-smi: %s", e.stderr)
191191
return []
192192
except Exception as e:
193-
logger.warning("Unexpected error: %s", e)
193+
logger.exception("Unexpected error during NPU device detection")
194194
return []
195195

196196

0 commit comments

Comments
 (0)