Skip to content

Commit 49ef925

Browse files
author
Ovtcharov
committed
fix(electron): update tests for SettingsModal→SettingsPage rename and version bump
- Update test_electron_chat_app.js to reference SettingsPage (renamed from SettingsModal in the card-layout settings PR #969) - Remove stale role="dialog"/aria-modal assertions (no longer a modal) - Fix danger-zone CSS assertions to match current class names - Bump package.json/package-lock.json to 0.17.6 to match version.py
1 parent ca3b345 commit 49ef925

3 files changed

Lines changed: 12 additions & 16 deletions

File tree

src/gaia/apps/webui/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/gaia/apps/webui/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@amd-gaia/agent-ui",
3-
"version": "0.17.5",
3+
"version": "0.17.6",
44
"type": "module",
55
"productName": "GAIA Agent UI",
66
"description": "Privacy-first agentic AI interface with document Q&A - runs 100% locally on AMD Ryzen AI",

tests/electron/test_electron_chat_app.js

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -460,9 +460,9 @@ describe('Chat App Integration', () => {
460460
expect(appContent).toContain('DocumentLibrary');
461461
});
462462

463-
it('should conditionally render SettingsModal', () => {
463+
it('should conditionally render SettingsPage', () => {
464464
expect(appContent).toContain('showSettings');
465-
expect(appContent).toContain('SettingsModal');
465+
expect(appContent).toContain('SettingsPage');
466466
});
467467
});
468468

@@ -526,7 +526,7 @@ describe('Chat App Integration', () => {
526526
describe('additional components', () => {
527527
const additionalComponents = [
528528
'DocumentLibrary',
529-
'SettingsModal',
529+
'SettingsPage',
530530
];
531531

532532
additionalComponents.forEach(name => {
@@ -1184,25 +1184,20 @@ describe('Chat App Integration', () => {
11841184

11851185
// ── Settings Modal Enhancements ───────────────────────────────────
11861186

1187-
describe('SettingsModal enhancements', () => {
1187+
describe('SettingsPage enhancements', () => {
11881188
let settingsContent;
11891189

11901190
beforeAll(() => {
1191-
const settingsPath = path.join(CHAT_APP_PATH, 'src/components/SettingsModal.tsx');
1191+
const settingsPath = path.join(CHAT_APP_PATH, 'src/components/SettingsPage.tsx');
11921192
settingsContent = fs.readFileSync(settingsPath, 'utf8');
11931193
});
11941194

11951195
it('should use dynamic version from build constant', () => {
11961196
expect(settingsContent).toContain('__APP_VERSION__');
11971197
});
11981198

1199-
it('should have ARIA role dialog', () => {
1200-
expect(settingsContent).toContain('role="dialog"');
1201-
expect(settingsContent).toContain('aria-modal="true"');
1202-
});
1203-
12041199
it('should have danger zone section at bottom', () => {
1205-
expect(settingsContent).toContain('danger-zone');
1200+
expect(settingsContent).toContain('danger-divider');
12061201
expect(settingsContent).toContain('danger-warning');
12071202
});
12081203

@@ -1211,16 +1206,17 @@ describe('Chat App Integration', () => {
12111206
});
12121207
});
12131208

1214-
describe('SettingsModal CSS enhancements', () => {
1209+
describe('SettingsPage CSS enhancements', () => {
12151210
let settingsCss;
12161211

12171212
beforeAll(() => {
1213+
// Danger-zone styles live in SettingsModal.css, which SettingsPage.tsx
1214+
// still imports (the component was renamed but the CSS file was kept).
12181215
const cssPath = path.join(CHAT_APP_PATH, 'src/components/SettingsModal.css');
12191216
settingsCss = fs.readFileSync(cssPath, 'utf8');
12201217
});
12211218

12221219
it('should have danger zone styles', () => {
1223-
expect(settingsCss).toContain('.danger-zone');
12241220
expect(settingsCss).toContain('.danger-divider');
12251221
expect(settingsCss).toContain('.danger-warning');
12261222
});

0 commit comments

Comments
 (0)