Skip to content

Commit 4f04a0b

Browse files
committed
fix(tests): update electron tests for SettingsModal→SettingsPage rename and version sync
SettingsModal.tsx was renamed to SettingsPage.tsx (full-page view, not a modal overlay) but test_electron_chat_app.js still referenced the old name, causing ENOENT failures. Also syncs package.json version to 0.17.6 to match version.py.
1 parent ac71861 commit 4f04a0b

2 files changed

Lines changed: 7 additions & 12 deletions

File tree

src/gaia/apps/webui/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@amd-gaia/agent-ui",
3-
"version": "0.17.5",
3+
"version": "0.17.6",
44
"type": "module",
55
"productName": "GAIA Agent UI",
66
"description": "Privacy-first agentic AI interface with document Q&A - runs 100% locally on AMD Ryzen AI",

tests/electron/test_electron_chat_app.js

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -460,9 +460,9 @@ describe('Chat App Integration', () => {
460460
expect(appContent).toContain('DocumentLibrary');
461461
});
462462

463-
it('should conditionally render SettingsModal', () => {
463+
it('should conditionally render SettingsPage', () => {
464464
expect(appContent).toContain('showSettings');
465-
expect(appContent).toContain('SettingsModal');
465+
expect(appContent).toContain('SettingsPage');
466466
});
467467
});
468468

@@ -526,7 +526,7 @@ describe('Chat App Integration', () => {
526526
describe('additional components', () => {
527527
const additionalComponents = [
528528
'DocumentLibrary',
529-
'SettingsModal',
529+
'SettingsPage',
530530
];
531531

532532
additionalComponents.forEach(name => {
@@ -1182,25 +1182,20 @@ describe('Chat App Integration', () => {
11821182
});
11831183
});
11841184

1185-
// ── Settings Modal Enhancements ───────────────────────────────────
1185+
// ── Settings Page Enhancements ───────────────────────────────────
11861186

1187-
describe('SettingsModal enhancements', () => {
1187+
describe('SettingsPage enhancements', () => {
11881188
let settingsContent;
11891189

11901190
beforeAll(() => {
1191-
const settingsPath = path.join(CHAT_APP_PATH, 'src/components/SettingsModal.tsx');
1191+
const settingsPath = path.join(CHAT_APP_PATH, 'src/components/SettingsPage.tsx');
11921192
settingsContent = fs.readFileSync(settingsPath, 'utf8');
11931193
});
11941194

11951195
it('should use dynamic version from build constant', () => {
11961196
expect(settingsContent).toContain('__APP_VERSION__');
11971197
});
11981198

1199-
it('should have ARIA role dialog', () => {
1200-
expect(settingsContent).toContain('role="dialog"');
1201-
expect(settingsContent).toContain('aria-modal="true"');
1202-
});
1203-
12041199
it('should have danger zone section at bottom', () => {
12051200
expect(settingsContent).toContain('danger-zone');
12061201
expect(settingsContent).toContain('danger-warning');

0 commit comments

Comments
 (0)