Commit bbf7062
fix(deps): make python-multipart a base dependency for gaia-mcp (#1380)
The v0.20.0 post-publish smoke test caught a real packaging bug: on a
clean `pip install amd-gaia`, the `gaia-mcp` command crashes immediately
with `ModuleNotFoundError: No module named 'python_multipart'`.
`gaia.mcp.mcp_bridge` imports `python_multipart` at module load, and
`gaia-mcp` is a **base** console_script — but `python-multipart` was
declared only in the `api`/`ui` extras (not even in `[mcp]`). So every
base install (and `pip install amd-gaia[mcp]`) shipped a broken
`gaia-mcp`.
Fix: move `python-multipart>=0.0.9` into base `install_requires`. After
this, `pip install amd-gaia` → `gaia-mcp --help` works, and the
post-publish smoke test passes.
Also adds a packaging regression test: if a base console_script's module
imports a third-party package at top level, that dist must be a base
dependency (not extras-only) — encoding the invariant this bug violated.
> Note: v0.20.0 is already published to PyPI immutably with the bug;
this fix ships in **0.20.1**.
## Test plan
- [x] `pytest tests/unit/test_packaging.py` — passes; new
`TestBaseDependencies` guard included
- [ ] Post-publish smoke test on the 0.20.1 tag reaches `gaia-mcp
--help` without `ModuleNotFoundError`
Co-authored-by: Ovtcharov <kovtchar@amd.com>1 parent 5e6f031 commit bbf7062
2 files changed
Lines changed: 46 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
112 | 116 | | |
113 | 117 | | |
114 | 118 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
60 | 75 | | |
61 | 76 | | |
62 | 77 | | |
| |||
189 | 204 | | |
190 | 205 | | |
191 | 206 | | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
0 commit comments