Please format your packages!

[Guelakais]

Trying the flake8 test on your package produce the following:

warning: Git tree '/home/ulysses/projects/nix/nixpkgs' is dirty
error: builder for '/nix/store/6gjdpwvnjycsq8yf6426r1cqad0z188s-python3.11-ament-package-0.17.2.drv' failed with exit code 1;
       last 25 log lines:
       >     ^
       > ./ament_package/template/prefix_level/_local_setup_util.py:407:5: F824 `global env_state` is unused: name is never assigned in scope
       >     global env_state
       >     ^
       > ./ament_package/template/prefix_level/_local_setup_util.py:415:5: F824 `global env_state` is unused: name is never assigned in scope
       >     global env_state
       >     ^
       > ./build/lib/ament_package/template/prefix_level/_local_setup_util.py:350:5: F824 `global env_state` is unused: name is never assigned in scope
       >     global env_state
       >     ^
       > ./build/lib/ament_package/template/prefix_level/_local_setup_util.py:372:5: F824 `global env_state` is unused: name is never assigned in scope
       >     global env_state
       >     ^
       > ./build/lib/ament_package/template/prefix_level/_local_setup_util.py:394:5: F824 `global env_state` is unused: name is never assigned in scope
       >     global env_state
       >     ^
       > ./build/lib/ament_package/template/prefix_level/_local_setup_util.py:407:5: F824 `global env_state` is unused: name is never assigned in scope
       >     global env_state
       >     ^
       > ./build/lib/ament_package/template/prefix_level/_local_setup_util.py:415:5: F824 `global env_state` is unused: name is never assigned in scope
       >     global env_state
       >     ^
       > =========================== short test summary info ============================
       > FAILED test/test_flake8.py::test_flake8 - AssertionError: Found code style errors / warnings
       > ============================== 1 failed in 0.48s ===============================
       For full logs, run:
         nix log /nix/store/6gjdpwvnjycsq8yf6426r1cqad0z188s-python3.11-ament-package-0.17.2.drv

Guys, honestly. I don't understand this. You build extra test environments into your packages and then they don't work. What's the point?

[mjcarroll]

Not sure, but maybe something about your environment here?

$ git clone https://github.com/ament/ament_package
$ cd ament_package
$ pytest
============================================================================ test session starts =============================================================================
platform linux -- Python 3.12.9, pytest-8.3.4, pluggy-1.5.0
rootdir: /usr/local/google/home/mjcarroll/workspaces/ros2_rolling2/src/ament/ament_package
configfile: pytest.ini
plugins: rerunfailures-15.0, anyio-4.7.0, typeguard-4.4.1, colcon-core-0.18.4, cov-5.0.0, repeat-0.9.3
collected 1 item                                                                                                                                                             

test/test_flake8.py .                                                                                                                                                  [100%]

============================================================================= 1 passed in 0.47s ==============================================================================

[mjcarroll]

Ah, this is actually a new check in recent flake8 versions: PyCQA/flake8#1976

Since the tests for this package run on Ubuntu Noble (24.04), this would not have appeared in the current CI runs. Would appreciate any patches you have for newer versions of flake8, as that will save effort when we advance versions for L-turtle and the 26.04 python versions.