-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathparser_test.go
More file actions
444 lines (381 loc) · 12.9 KB
/
parser_test.go
File metadata and controls
444 lines (381 loc) · 12.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
package gin
import (
stderrors "errors"
"fmt"
"strings"
"testing"
"github.com/pkg/errors"
)
func TestWithParserRejectsNil(t *testing.T) {
opt := WithParser(nil)
b := &GINBuilder{}
err := opt(b)
if err == nil {
t.Fatal("expected error, got nil")
}
if err.Error() != "parser cannot be nil" {
t.Fatalf("want %q, got %q", "parser cannot be nil", err.Error())
}
}
func TestStdlibParserName(t *testing.T) {
if got := (stdlibParser{}).Name(); got != stdlibParserName {
t.Fatalf("stdlibParser.Name() = %q, want %q", got, stdlibParserName)
}
}
var (
_ parserSink = (*GINBuilder)(nil)
_ Parser = stdlibParser{}
)
func TestBuilderHasParserFields(t *testing.T) {
b, err := NewBuilder(DefaultConfig(), 4)
if err != nil {
t.Fatalf("NewBuilder: %v", err)
}
b.parserName = "xyz"
b.currentDocState = newDocumentBuildState(0)
if b.parserName != "xyz" || b.currentDocState == nil {
t.Fatal("parser fields not writable/readable")
}
}
func TestShouldBufferForTransformSignalWhenRegistered(t *testing.T) {
cfg := DefaultConfig()
if err := WithISODateTransformer("$.created_at", "epoch_ms")(&cfg); err != nil {
t.Fatalf("WithISODateTransformer: %v", err)
}
b, err := NewBuilder(cfg, 4)
if err != nil {
t.Fatalf("NewBuilder: %v", err)
}
if !b.ShouldBufferForTransform("$.created_at") {
t.Errorf("expected ShouldBufferForTransform(\"$.created_at\") == true")
}
if b.ShouldBufferForTransform("$.other") {
t.Errorf("expected ShouldBufferForTransform(\"$.other\") == false")
}
}
func TestBeginDocumentStashesState(t *testing.T) {
b, err := NewBuilder(DefaultConfig(), 4)
if err != nil {
t.Fatalf("NewBuilder: %v", err)
}
state := b.BeginDocument(2)
if state == nil {
t.Fatal("BeginDocument returned nil")
}
if state.rgID != 2 {
t.Errorf("state.rgID = %d, want 2", state.rgID)
}
if b.currentDocState != state {
t.Error("b.currentDocState not stashed to returned state")
}
}
func TestNewBuilderDefaultsToStdlibParser(t *testing.T) {
b, err := NewBuilder(DefaultConfig(), 4)
if err != nil {
t.Fatalf("NewBuilder: %v", err)
}
if b.parser == nil {
t.Fatal("b.parser is nil; expected stdlibParser{}")
}
if b.parserName != stdlibParserName {
t.Errorf("b.parserName = %q, want %q", b.parserName, stdlibParserName)
}
if _, ok := b.parser.(stdlibParser); !ok {
t.Errorf("b.parser concrete type = %T, want stdlibParser", b.parser)
}
}
type emptyNameParser struct{}
func (emptyNameParser) Name() string { return "" }
func (emptyNameParser) Parse([]byte, int, parserSink) error { return nil }
func TestNewBuilderRejectsEmptyParserName(t *testing.T) {
_, err := NewBuilder(DefaultConfig(), 4, WithParser(emptyNameParser{}))
if err == nil {
t.Fatal("expected error, got nil")
}
if err.Error() != "parser name cannot be empty" {
t.Fatalf("want %q, got %q", "parser name cannot be empty", err.Error())
}
}
func TestBuilderParserNameReachable(t *testing.T) {
b, err := NewBuilder(DefaultConfig(), 4)
if err != nil {
t.Fatalf("NewBuilder: %v", err)
}
if b.parserName != stdlibParserName {
t.Errorf("b.parserName = %q, want %q", b.parserName, stdlibParserName)
}
}
type namedParser struct{ name string }
func (p namedParser) Name() string { return p.name }
func (p namedParser) Parse([]byte, int, parserSink) error { return nil }
func TestWithParserAcceptsCustomParser(t *testing.T) {
b, err := NewBuilder(DefaultConfig(), 4, WithParser(namedParser{name: "custom-v1"}))
if err != nil {
t.Fatalf("NewBuilder: %v", err)
}
if b.parserName != "custom-v1" {
t.Errorf("b.parserName = %q, want %q", b.parserName, "custom-v1")
}
}
func TestAddDocumentRoundTripsThroughParser(t *testing.T) {
b, err := NewBuilder(DefaultConfig(), 4)
if err != nil {
t.Fatalf("NewBuilder: %v", err)
}
if err := b.AddDocument(DocID(0), []byte(`{"a": 1, "b": "hello"}`)); err != nil {
t.Fatalf("AddDocument: %v", err)
}
idx := b.Finalize()
got := idx.Evaluate([]Predicate{EQ("$.a", int64(1))}).ToSlice()
want := []int{0}
if len(got) != len(want) || got[0] != want[0] {
t.Errorf("Evaluate got %v, want %v", got, want)
}
}
func TestAddDocumentResetsBeginDocumentCallCounter(t *testing.T) {
b, err := NewBuilder(DefaultConfig(), 2)
if err != nil {
t.Fatalf("NewBuilder: %v", err)
}
if err := b.AddDocument(DocID(0), []byte(`{"a":1}`)); err != nil {
t.Fatalf("first AddDocument: %v", err)
}
if b.beginDocumentCalls != 0 {
t.Fatalf("beginDocumentCalls after first AddDocument = %d, want 0", b.beginDocumentCalls)
}
if b.currentDocState != nil {
t.Fatal("currentDocState should be cleared after first AddDocument")
}
if err := b.AddDocument(DocID(1), []byte(`{"a":2}`)); err != nil {
t.Fatalf("second AddDocument: %v", err)
}
if b.beginDocumentCalls != 0 {
t.Fatalf("beginDocumentCalls after second AddDocument = %d, want 0", b.beginDocumentCalls)
}
if b.currentDocState != nil {
t.Fatal("currentDocState should be cleared after second AddDocument")
}
}
type recordingSink struct {
events []string
bufferPaths map[string]bool
}
func (s *recordingSink) BeginDocument(rgID int) *documentBuildState {
s.events = append(s.events, fmt.Sprintf("begin:%d", rgID))
return newDocumentBuildState(rgID)
}
func (s *recordingSink) MarkPresent(_ *documentBuildState, canonicalPath string) {
s.events = append(s.events, "present:"+canonicalPath)
}
func (s *recordingSink) StageScalar(_ *documentBuildState, canonicalPath string, _ any) error {
s.events = append(s.events, "scalar:"+canonicalPath)
return nil
}
func (s *recordingSink) StageJSONNumber(_ *documentBuildState, canonicalPath, raw string) error {
s.events = append(s.events, "json-number:"+canonicalPath+"="+raw)
return nil
}
func (s *recordingSink) StageNativeNumeric(_ *documentBuildState, canonicalPath string, _ any) error {
s.events = append(s.events, "native-number:"+canonicalPath)
return nil
}
func (s *recordingSink) StageMaterialized(_ *documentBuildState, path string, _ any, _ bool) error {
s.events = append(s.events, "materialized:"+path)
return nil
}
func (s *recordingSink) ShouldBufferForTransform(canonicalPath string) bool {
return s.bufferPaths[canonicalPath]
}
func TestStdlibParserBeginsDocumentBeforeStaging(t *testing.T) {
sink := &recordingSink{}
if err := (stdlibParser{}).Parse([]byte(`{"a":1}`), 3, sink); err != nil {
t.Fatalf("Parse: %v", err)
}
want := []string{"begin:3", "present:$", "materialized:$.a"}
if len(sink.events) != len(want) {
t.Fatalf("events = %v, want %v", sink.events, want)
}
for i := range want {
if sink.events[i] != want[i] {
t.Fatalf("events[%d] = %q, want %q (full events %v)", i, sink.events[i], want[i], sink.events)
}
}
}
func TestStdlibParserBuffersTransformedRootOnGenericSink(t *testing.T) {
sink := &recordingSink{
bufferPaths: map[string]bool{"$": true},
}
if err := (stdlibParser{}).Parse([]byte(`{"a":1}`), 4, sink); err != nil {
t.Fatalf("Parse: %v", err)
}
want := []string{"begin:4", "materialized:$"}
if len(sink.events) != len(want) {
t.Fatalf("events = %v, want %v", sink.events, want)
}
for i := range want {
if sink.events[i] != want[i] {
t.Fatalf("events[%d] = %q, want %q (full events %v)", i, sink.events[i], want[i], sink.events)
}
}
}
func TestStdlibParserStagesArrayIndexAndWildcardOnGenericSink(t *testing.T) {
sink := &recordingSink{}
if err := (stdlibParser{}).Parse([]byte(`[{"x":1}]`), 5, sink); err != nil {
t.Fatalf("Parse: %v", err)
}
want := []string{"begin:5", "present:$", "materialized:$[0]", "materialized:$[*]"}
if len(sink.events) != len(want) {
t.Fatalf("events = %v, want %v", sink.events, want)
}
for i := range want {
if sink.events[i] != want[i] {
t.Fatalf("events[%d] = %q, want %q (full events %v)", i, sink.events[i], want[i], sink.events)
}
}
}
type failingParser struct{ err error }
func (p failingParser) Name() string { return "failing" }
func (p failingParser) Parse(_ []byte, rgID int, sink parserSink) error {
_ = sink.BeginDocument(rgID)
return p.err
}
func TestAddDocumentReturnsParserIngestError(t *testing.T) {
sentinel := errors.New("sentinel parse error")
b, err := NewBuilder(DefaultConfig(), 4, WithParser(failingParser{err: sentinel}))
if err != nil {
t.Fatalf("NewBuilder: %v", err)
}
got := b.AddDocument(DocID(0), []byte(`{"a": 1}`))
if got == nil {
t.Fatal("expected error from AddDocument, got nil")
}
var ingestErr *IngestError
if !stderrors.As(got, &ingestErr) {
t.Fatalf("AddDocument error = %v, want *IngestError", got)
}
if ingestErr.Layer() != IngestLayerParser || ingestErr.Path() != "" || !stderrors.Is(ingestErr.Cause(), sentinel) {
t.Fatalf("IngestError = %+v, want parser layer, unknown path, sentinel cause", ingestErr)
}
}
func TestAddDocumentDefaultParserErrorStringsPreserved(t *testing.T) {
cases := []struct {
name string
jsonDoc string
wantSubstr string
}{
{name: "garbage", jsonDoc: "garbage", wantSubstr: "read JSON token"},
{name: "bad-object-value", jsonDoc: `{"a":}`, wantSubstr: "parse object value at $.a"},
{name: "bad-object-key", jsonDoc: `{1:true}`, wantSubstr: "read object key at $"},
{name: "unterminated-object", jsonDoc: `{"a":1`, wantSubstr: "close object at $"},
{name: "unterminated-array", jsonDoc: `[1,`, wantSubstr: "parse array element at $[1]"},
{name: "trailing-json", jsonDoc: `{"a":1} []`, wantSubstr: "unexpected trailing JSON content"},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
b, err := NewBuilder(DefaultConfig(), 4)
if err != nil {
t.Fatalf("NewBuilder: %v", err)
}
got := b.AddDocument(DocID(0), []byte(tc.jsonDoc))
if got == nil {
t.Fatalf("expected error from AddDocument(%q), got nil", tc.jsonDoc)
}
if msg := got.Error(); !strings.Contains(msg, tc.wantSubstr) {
t.Fatalf("AddDocument err = %q, want substring %q", msg, tc.wantSubstr)
}
})
}
}
type skipBeginDocumentParser struct{}
func (skipBeginDocumentParser) Name() string { return "skip-begin" }
func (skipBeginDocumentParser) Parse([]byte, int, parserSink) error {
return nil
}
func TestAddDocumentRejectsParserSkippingBeginDocument(t *testing.T) {
b, err := NewBuilder(DefaultConfig(), 4, WithParser(skipBeginDocumentParser{}))
if err != nil {
t.Fatalf("NewBuilder: %v", err)
}
err = b.AddDocument(DocID(0), []byte(`{"a":1}`))
if err == nil {
t.Fatal("expected error from AddDocument when parser skips BeginDocument, got nil")
}
if !strings.Contains(err.Error(), "did not call BeginDocument") {
t.Fatalf("want error containing %q, got %q", "did not call BeginDocument", err.Error())
}
}
type doubleBeginDocumentParser struct{}
func (doubleBeginDocumentParser) Name() string { return "double-begin" }
func (doubleBeginDocumentParser) Parse(_ []byte, rgID int, sink parserSink) error {
_ = sink.BeginDocument(rgID)
_ = sink.BeginDocument(rgID)
return nil
}
func TestAddDocumentRejectsParserCallingBeginDocumentTwice(t *testing.T) {
b, err := NewBuilder(DefaultConfig(), 4, WithParser(doubleBeginDocumentParser{}))
if err != nil {
t.Fatalf("NewBuilder: %v", err)
}
err = b.AddDocument(DocID(0), []byte(`{"a":1}`))
if err == nil {
t.Fatal("expected duplicate BeginDocument error, got nil")
}
if !strings.Contains(err.Error(), "called BeginDocument 2 times") {
t.Fatalf("want duplicate BeginDocument error, got %q", err.Error())
}
}
type wrongRGIDParser struct{}
func (wrongRGIDParser) Name() string { return "wrong-rgid" }
func (wrongRGIDParser) Parse(_ []byte, rgID int, sink parserSink) error {
_ = sink.BeginDocument(rgID + 7)
return nil
}
func TestAddDocumentRejectsBeginDocumentRGIDMismatch(t *testing.T) {
b, err := NewBuilder(DefaultConfig(), 4, WithParser(wrongRGIDParser{}))
if err != nil {
t.Fatalf("NewBuilder: %v", err)
}
err = b.AddDocument(DocID(0), []byte(`{"a":1}`))
if err == nil {
t.Fatal("expected rgID-mismatch error, got nil")
}
if !strings.Contains(err.Error(), "BeginDocument rgID mismatch") {
t.Fatalf("want error containing %q, got %q", "BeginDocument rgID mismatch", err.Error())
}
}
type fixedRGIDParser struct {
name string
rgID int
}
func (p fixedRGIDParser) Name() string { return p.name }
func (p fixedRGIDParser) Parse(_ []byte, _ int, sink parserSink) error {
_ = sink.BeginDocument(p.rgID)
return nil
}
func TestAddDocumentRejectsOutOfRangeBeginDocumentRGID(t *testing.T) {
cases := []struct {
name string
rgID int
}{
{name: "negative", rgID: -1},
{name: "past-numrgs", rgID: 9},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
b, err := NewBuilder(DefaultConfig(), 4, WithParser(fixedRGIDParser{name: tc.name, rgID: tc.rgID}))
if err != nil {
t.Fatalf("NewBuilder: %v", err)
}
err = b.AddDocument(DocID(0), []byte(`{"a":1}`))
if err == nil {
t.Fatal("expected rgID-mismatch error, got nil")
}
if !strings.Contains(err.Error(), "BeginDocument rgID mismatch") {
t.Fatalf("want mismatch error, got %q", err.Error())
}
if !strings.Contains(err.Error(), fmt.Sprintf("got %d, want 0", tc.rgID)) {
t.Fatalf("want mismatch details for rgID %d, got %q", tc.rgID, err.Error())
}
})
}
}