Add TLS flag propagation to ServerSession.url() with shim FFI and config support#88
Draft
Copilot wants to merge 2 commits into
Draft
Add TLS flag propagation to ServerSession.url() with shim FFI and config support#88Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…ropagation Agent-Logs-Url: https://github.com/amikos-tech/chroma-go-local/sessions/187dd255-b99b-4339-9576-faec7646b9d7 Co-authored-by: tazarov <1157440+tazarov@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add TLS support for self-signed certificates in ServerSession.url()
Add TLS flag propagation to ServerSession.url() with shim FFI and config support
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServerSession.url()(Java) andServer.URL()(Go) hardcodedhttp://. This adds the plumbing to detect a TLS-configured server and returnhttps://instead, with config builder support for cert/key paths.Rust shim
tls_enabled: booltoServerHandle, set by parsingtls_cert_pathfrom the startup YAML via a lightweightShimTlsConfigstruct (independent ofFrontendServerConfig, which has no TLS fields)chroma_server_tls_enabledFFI export — returns1(enabled),0(disabled),-1(error)Go
WithTLSCertPath(string)/WithTLSKeyPath(string)server options; serialised astls_cert_path/tls_key_pathin config YAMLServer.tls boolpopulated at startup viachroma_server_tls_enabled;URL()selectshttp/httpsaccordingly;TLS() boolaccessor addedJava
ServerSessionconstructor gainsBooleanSupplier tlsEnabledAccessor(param 7, afterpersistPathAccessor);url()uses it to choose scheme; newtlsEnabled()accessorServerConfigBuildergains.tlsCertPath()/.tlsKeyPath()fluent setters emitting the YAML keyschroma_server_tls_enabledand pass() -> serverTlsEnabled(handle)intoServerSessionKnown issue
MaintenanceExecutorTest.javawas missed in theServerSessionconstructor update and needs() -> falseadded as parameter 7 — will cause a Java compile failure and must be fixed before merge.