Skip to content

Commit 1bfd114

Browse files
authored
[ENH] Only enrich dirty logs from s3, not repl. (chroma-core#6463)
## Description of changes The dirty log on S3 needs to enrich itself to purge markers. The dirty log on repl is self-healing and doesn't need to enrich itself. Remove the enrichment to make the dirty-log rollup fast. ## Test plan Local for wal3/chroma-log-service. CI for the rest. ## Migration plan N/A ## Observability plan Watch staging. ## Documentation Changes N/A
1 parent 2ed2583 commit 1bfd114

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

rust/log-service/src/lib.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1432,7 +1432,6 @@ impl LogServer {
14321432
rollups.insert((Some(topology.name.clone()), collection_id), rollup);
14331433
}
14341434
let mut backpressure = vec![];
1435-
self.enrich_dirty_log(&mut rollups).await?;
14361435
for ((_, collection_id), rollup) in rollups.iter() {
14371436
if rollup.requires_backpressure(self.config.num_records_before_backpressure) {
14381437
backpressure.push(*collection_id);

0 commit comments

Comments
 (0)