Skip to content

Release 0.1.24#109

Merged
tazarov merged 20 commits into
releasefrom
main
May 23, 2025
Merged

Release 0.1.24#109
tazarov merged 20 commits into
releasefrom
main

Conversation

@tazarov

@tazarov tazarov commented May 23, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the chart label May 23, 2025
Comment thread README.md Outdated
dependencies:
- name: chromadb
version: 0.1.22
version: 0.1.23

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency version in the README example should be updated from 0.1.23 to 0.1.24 to match the new chart version being released in this PR. This ensures users following the documentation will use the latest version.

Suggested change
version: 0.1.23
version: 0.1.24

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

password: null # The string used as the auth.basic password. Only used if value not null, otherwise a random string will be generated and used.
token:
headerType: "Authorization" #possible values Authorization, X-Chroma-Token
headerType: "Authorization" #possible values Authorization, X-Chroma-Token

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a duplicate configuration entry for headerType: "Authorization" in the values.yaml file. The same line appears twice at lines 128 and 134. One of these duplicate entries should be removed to maintain clean configuration and prevent potential confusion.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

```
{{ else }}
```bash
export CHROMA_TOKEN=$(kubectl --namespace default get secret chromadb-auth -o jsonpath="{.data.token}" | base64 --decode)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The namespace in this command is hardcoded to default, which may not match the actual release namespace. Consider updating it to use the dynamic namespace value:

export CHROMA_TOKEN=$(kubectl --namespace {{ .Release.Namespace }} get secret chromadb-auth -o jsonpath="{.data.token}" | base64 --decode)

This ensures the command works correctly regardless of which namespace the chart is deployed to.

Suggested change
export CHROMA_TOKEN=$(kubectl --namespace default get secret chromadb-auth -o jsonpath="{.data.token}" | base64 --decode)
export CHROMA_TOKEN=$(kubectl --namespace {{ .Release.Namespace }} get secret chromadb-auth -o jsonpath="{.data.token}" | base64 --decode)

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@tazarov tazarov merged commit 5a08568 into release May 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant