feat: Ability to have global imagepullsecrets#117
Merged
tazarov merged 3 commits intoFeb 17, 2026
Conversation
Guard against nil values when .Values.global or .Values.global.imagePullSecrets is undefined by checking .Values.global exists before accessing its keys and using default empty lists in concat to prevent template errors when used as a subchart.
tazarov
force-pushed
the
feature/imagepullsecrets_from_global
branch
from
a3a9bf9 to
e439ee0
Compare
Document both chart-level and global imagePullSecrets values in the configuration table. Add explanation in the subchart dependency section for why both exist and how they are merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is handy when using this chart in a umbrella chart