fix: align legacy values behavior/docs for >=1.0.0#131
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #126 by properly gating legacy Python-era configuration to ChromaDB versions < 1.0.0, preventing invalid rendering when deploying the Rust server (>= 1.0.0) with legacy auth/logging settings. The PR fixes a bug where basic auth would attempt to set up htpasswd init containers on >= 1.0.0 deployments, and comprehensively documents which values.yaml options are ignored in modern versions.
Changes:
- Gate legacy Python auth/logging resources (ConfigMaps, Secrets, init containers, volume mounts) to
< 1.0.0only - Fix invalid htpasswd init container setup when deploying
>= 1.0.0withchromadb.auth.type: basic - Document legacy value behavior in
values.yamland README with clear version range annotations
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/chromadb-chart/values.yaml | Added inline comments marking legacy values (logging, auth, maintenance, telemetry) as ignored for >= 1.0.0 |
| charts/chromadb-chart/templates/config.yaml | Introduced $isLegacy variable to gate log-config ConfigMap and auth resources to < 1.0.0 only |
| charts/chromadb-chart/templates/statefulset.yaml | Added < 1.0.0 check to htpasswd init container and nested log-config volume mounting under version gate |
| charts/chromadb-chart/templates/tests/test-connection.yaml | Added version and enabled checks to auth header logic, removed stale TODO comments |
| charts/chromadb-chart/templates/tests/test-api.yaml | Added version and enabled checks to auth header logic, removed stale TODO comments |
| README.md | Updated configuration table with version applicability, corrected tokenHeader → headerType typo, added dedicated legacy values section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
< 1.0.0only>= 1.0.0 + basic authrender path by preventing legacyhtpasswdinit container setup on v1values.yamland README (includingisPersistentsemantics)chromadb.apiImplas removed/no-op and clean stale TODO comments in test templateschromadb.auth.token.headerTypeand explicit supported version rangesTesting
helm lint charts/chromadb-chartbash tests/test_v1_config.sh(57 passed, 0 failed)pytest -q(fails during collection intests/test_chroma.pyduesentence-transformers/all-MiniLM-L6-v2model resolution)Fixes #126