Skip to content

Commit 79fe625

Browse files
committed
release: cleanup temp error files on workflow exits
1 parent 756d2a7 commit 79fe625

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

.github/workflows/rust-release.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,6 +297,7 @@ jobs:
297297
set -euo pipefail
298298
PREFIX="s3://${BUCKET}/${PROJECT}/${VERSION}/"
299299
immutability_check_err="/tmp/immutability-check.err"
300+
trap 'rm -f "${immutability_check_err}"' EXIT
300301
if ! existing_prefix_listing="$(aws s3 ls "${PREFIX}" --endpoint-url "${R2_ENDPOINT}" 2>"${immutability_check_err}")"; then
301302
echo "Failed to check release immutability for ${PREFIX}." >&2
302303
cat "${immutability_check_err}" >&2
@@ -316,6 +317,8 @@ jobs:
316317
AWS_SECRET_ACCESS_KEY: ${{ secrets.R2_SECRET_ACCESS_KEY }}
317318
run: |
318319
set -euo pipefail
320+
releases_fetch_err="/tmp/releases-fetch.err"
321+
trap 'rm -f "${releases_fetch_err}"' EXIT
319322
aws s3 cp dist/ "s3://${BUCKET}/${PROJECT}/${VERSION}/" \
320323
--recursive \
321324
--endpoint-url "${R2_ENDPOINT}"
@@ -335,7 +338,6 @@ jobs:
335338
336339
# Maintain bounded project release history for clients that need more than latest.json.
337340
# This logic is externalized to a script so it can be tested locally.
338-
releases_fetch_err="/tmp/releases-fetch.err"
339341
if ! aws s3 cp "s3://${BUCKET}/${PROJECT}/releases.json" /tmp/releases-existing.json \
340342
--endpoint-url "${R2_ENDPOINT}" 2>"${releases_fetch_err}"; then
341343
if grep -qiE '404|NoSuchKey' "${releases_fetch_err}"; then

0 commit comments

Comments
 (0)