fix: correct build condition logic and musl library extension

Critical fixes:
1. Fix Linux native cargo build condition (build-rust-library:74)
   - Changed from complex AND logic to simple 'use-cross == false' check
   - Previous logic would never execute on Linux when use-cross='false'
   - Now correctly falls back to native cargo when explicitly disabled

2. Fix musl library extension mismatch (build-rust-library:95-96)
   - Changed from .a (static) to .so (shared) for musl targets
   - Matches actual Cargo.toml: crate-type = ["cdylib", "staticlib"]
   - Prevents "Library not found" errors on musl targets

3. Remove redundant use-cross setting (rust-ci.yml:100)
   - Action already defaults to 'auto' which handles platform detection
   - Explicit setting was duplicating built-in logic
   - Added comment explaining the default behavior

Minor fixes:
4. Change PowerShell 'return' to 'exit 0' (get-rust-library:154)
   - Consistent with bash scripts' exit behavior
   - More explicit about success exit code

5. Update README.md documentation
   - Clarify build selection logic with numbered steps
   - Document that musl produces .so not .a files
   - Add library output format information

Author: tazarov

.github/actions/README.md

@@ -100,7 +100,13 @@ The composite actions follow a layered approach:
 **Build Selection Logic**:
 1. If `use-zigbuild='true'` → uses cargo-zigbuild
 2. Else if Linux + `use-cross='true'|'auto'` → uses cross
-3. Else → uses native cargo
+3. Else if `use-cross='false'` → uses native cargo
+4. Note: Default is `'auto'` which uses cross on Linux, native elsewhere
+
+**Library Output**:
+- All platforms produce shared libraries (.so/.dylib/.dll)
+- musl targets produce `.so` (cdylib), not `.a` static libraries
+- Cargo.toml specifies `crate-type = ["cdylib", "staticlib"]`
 
 ---
 

.github/actions/build-rust-library/action.yml

@@ -65,13 +65,13 @@ runs:
       run: cargo zigbuild --release --target ${{ inputs.target }}
 
     - name: Build with cargo (native)
-      # Fallback: macOS, Windows, or Linux when not using cross/zigbuild
+      # Fallback: macOS, Windows, or Linux when explicitly skipping cross/zigbuild
       # Note: Uses bash shell even on Windows (via Git Bash) for consistency
       # with other build steps and cross-platform script compatibility
       if: |
         (runner.os == 'macOS' || runner.os == 'Windows' || runner.os == 'Linux') &&
         inputs.use-zigbuild != 'true' &&
-        (inputs.use-cross != 'true' && inputs.use-cross != 'auto')
+        inputs.use-cross == 'false'
       shell: bash
       run: cargo build --release --target ${{ inputs.target }}
 
@@ -82,6 +82,8 @@ runs:
         set -euo pipefail
 
         # Determine library name based on target
+        # Note: Cargo.toml specifies crate-type = ["cdylib", "staticlib"]
+        # We use the shared library (.so/.dylib/.dll) for all platforms
         case "${{ inputs.target }}" in
           *-apple-darwin)
             LIB_NAME="libtokenizers.dylib"
@@ -90,7 +92,8 @@ runs:
             LIB_NAME="libtokenizers.so"
             ;;
           *-unknown-linux-musl)
-            LIB_NAME="libtokenizers.a"
+            # musl targets also produce .so (cdylib), not .a
+            LIB_NAME="libtokenizers.so"
             ;;
           *-pc-windows-msvc)
             LIB_NAME="tokenizers.dll"

.github/actions/get-rust-library/action.yml

@@ -151,7 +151,7 @@ runs:
                   Write-Host "Checksum verification failed, building locally instead"
                   cargo build --release
                   "TOKENIZERS_LIB_PATH=$(Get-Location)\target\release\tokenizers.dll" | Out-File -FilePath $env:GITHUB_ENV -Append
-                  return
+                  exit 0
                 }
               } else {
                 Write-Host "Warning: No checksum file found, skipping verification"

.github/workflows/rust-ci.yml

@@ -97,4 +97,4 @@ jobs:
       uses: ./.github/actions/build-rust-library
       with:
         target: ${{ matrix.target }}
-        use-cross: ${{ matrix.os == 'ubuntu-latest' && 'true' || 'false' }}
+        # use-cross defaults to 'auto' which automatically uses cross on Linux