You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Overall this is a clean, well-scoped dependency bump. A few notes:
Positive
Diff is minimal: only Cargo.toml and Cargo.lock — no FFI surface changes, which is what matters for ABI stability.
Transitive updates (console, indicatif → unit-prefix, portable-atomic, windows-sys 0.61.2) are all lock-file level and don't affect the public API.
Concern: API compatibility between 0.21.4 → 0.22.2 not explicitly verified
The PR description lists cargo check / cargo test as validation steps, which confirms the code compiles and unit tests pass. However, tokenizers minor-version bumps sometimes include behavioral changes (e.g., tokenization output differences for edge-case inputs). It would be good to confirm:
The HuggingFace tokenizers 0.22.x changelog/releases was reviewed for any behavioral changes that could affect encoding/decoding output.
Integration tests (e.g., make test or go test ./...) pass against a real model — the PR mentions go test ./... -count=1 was run, which is good.
Minor pre-existing issue (not blocking this PR) cbindgen = "0.29.0" in [dependencies] should be [build-dependencies] since it's a code-generation tool, not a runtime dependency. This inflates the binary unnecessarily. Worth a follow-up issue.
Overall: looks good to merge assuming CI passes and the changelog was reviewed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tokenizersfrom0.21.4to0.22.2Cargo.lockto capture resolved transitive updatesValidation
cargo checkcargo test --libcargo test --all-targetsgo test ./... -count=1