Skip to content

Commit 372e48c

Browse files
authored
fix(resource/iam_idp_openid): allow unknown value for client_secret_wo during plan (#900)
Same issue as #898 (fixed by #899) but for the OpenID resource. The plan-time checks treated ephemeral/unknown values as missing, breaking write-only secret rotation from Vault. Schema RequiredWith and the apply-time check in Update keep the safety net intact. Co-authored-by: aminueza <aminueza@users.noreply.github.com>
1 parent 244180b commit 372e48c

1 file changed

Lines changed: 0 additions & 10 deletions

File tree

minio/resource_minio_iam_idp_openid.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,6 @@ func resourceMinioIAMIdpOpenId() *schema.Resource {
3838
return fmt.Errorf("one of client_secret or client_secret_wo must be provided")
3939
}
4040

41-
_, hasVersionWO := d.GetOk("client_secret_wo_version")
42-
if hasSecretWO && !hasVersionWO {
43-
return fmt.Errorf("client_secret_wo_version must be provided when client_secret_wo is set")
44-
}
45-
46-
hasSecretWOVersionChange := d.HasChange("client_secret_wo_version") && hasVersionWO
47-
if hasSecretWOVersionChange && !hasSecretWO {
48-
return fmt.Errorf("client_secret_wo must be provided when client_secret_wo_version changes")
49-
}
50-
5141
return nil
5242
},
5343
Schema: map[string]*schema.Schema{

0 commit comments

Comments
 (0)