Skip to content

dynamic_project_options:  #239

Open
Open
@samwhitlock

Description

Either something is fundamentally broken with dynamic_project_options or I'm sorely misunderstanding how to use it.

My understanding of the intent is as follows:

  • Create an option called OPT_${option_name} that is configurable afterward running CMake (e.g. through ccmake).
  • Use the option named OPT_${option_name} if it is specified (usually through the cmake command line).
  • Else pick either the developer or user value for that value, which is determined based on whether ENABLE_DEVELOPER_MODE is toggled.

What am I seeing in the error?

This is the sample CMake file I used, which is just a slightly modified version of the example one in the dynamic project options file.

CMakeLists.txt

If I invoke it like this:

cmake -S . -B ./build -G Ninja -DOPT_GCC_WARNINGS="-Wdouble-conversion"

I'd expect there to be an option called OPT_GCC_WARNINGS with that given value (and a user default of "-WBaz" based on the lack of developer options being enabled).

If I invoke it without the OPT_GCC_WARNINGS on the command line, I would expect there to be no option available (based on the cmake_dependent_option use in DynamicProjectOptions), but that a hidden one be populated with the value "-WBaz". Instead, I find an option called OPT_GCC_WARNINGS that has the value OFF.

I suspect that either I misunderstand how to use this tool properly, or that this worked at one point but some subtle CMake variable creation behavior changed recently and broke it (and maybe I'm the only one to use this dynamic macro?).

I'm happy to help test this out further. I was hoping to just submit a PR, but I'm really stuck on this so I don't have a solution yet.

Upvote & Fund

  • I am using Polar.sh so you can upvote and help fund this issue. The funding is received once the issue is completed & confirmed by you.

  • Thank you in advance for helping prioritize & fund our backlog.

Fund with Polar

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions