Exclude users with a negative score from email eligibility. (forem#22818)

* Exclude users with a negative score from email eligibility.

* Add throttle

Author: benhalpern

app/models/user.rb

@@ -189,6 +189,7 @@ class User < ApplicationRecord
         .without_role(:spam)
         .where(notification_setting: { email_newsletter: true })
         .where.not(email: ["", nil])
+        .where("users.score >= 0")
     end
   }
   scope :invited, -> { where(registered: false) }
@@ -266,7 +267,7 @@ class User < ApplicationRecord
 
   after_create_commit :send_welcome_notification
 
-  after_save :sync_base_email_eligible!, if: -> { saved_changes.key?(:email) || saved_changes.key?(:registered) }
+  after_save :sync_base_email_eligible!, if: -> { saved_changes.key?(:email) || saved_changes.key?(:registered) || saved_changes.key?(:score) }
   after_save :create_conditional_autovomits
   after_save :generate_social_images
   after_commit :subscribe_to_mailchimp_newsletter
@@ -346,6 +347,7 @@ def calculate_score
     calculated_score = (badge_achievements_count * 10) + user_reaction_points
     calculated_score -= 500 if spam?
     update_column(:score, calculated_score)
+    sync_base_email_eligible!
     AlgoliaSearch::SearchIndexWorker.perform_async(self.class.name, id, false)
   end
 
@@ -748,12 +750,13 @@ def update_presence!
 
   def sync_base_email_eligible!
     # User is eligible if they are registered, have an email, are not suspended,
-    # not marked as spam, and have email_newsletter set to true.
+    # not marked as spam, have email_newsletter set to true, and their score is not below zero.
     is_eligible = registered? &&
                   email.present? &&
                   !has_role?(:suspended) &&
                   !has_role?(:spam) &&
-                  notification_setting&.email_newsletter?
+                  notification_setting&.email_newsletter? &&
+                  score.to_i >= 0
 
     if has_attribute?(:base_email_eligible) && self[:base_email_eligible] != is_eligible
       update_column(:base_email_eligible, is_eligible)

app/workers/badge_achievements/send_email_notification_worker.rb

@@ -1,6 +1,9 @@
 module BadgeAchievements
   class SendEmailNotificationWorker
     include Sidekiq::Job
+    include Sidekiq::Throttled::Job
+
+    sidekiq_throttle(concurrency: { limit: 8 })
 
     sidekiq_options queue: :low_priority, retry: 10
 

spec/models/user_email_eligible_spec.rb

@@ -39,6 +39,18 @@
       expect(user.base_email_eligible).to eq(false)
     end
 
+    it "sets to false when score is below zero" do
+      user.update!(score: -1)
+      expect(user.base_email_eligible).to eq(false)
+    end
+
+    it "sets to true when score is directly set to zero or above" do
+      user.update!(score: 0)
+      expect(user.base_email_eligible).to eq(true)
+      user.update!(score: 1)
+      expect(user.base_email_eligible).to eq(true)
+    end
+
     it "syncs correctly when role is removed" do
       user.add_role(:suspended)
       expect(user.base_email_eligible).to eq(false)
@@ -102,6 +114,14 @@
       user.notification_setting.update!(email_newsletter: true)
       expect(user.reload.base_email_eligible).to eq(true)
     end
+
+    it "syncs when score is updated" do
+      user.update!(score: -10)
+      expect(user.reload.base_email_eligible).to eq(false)
+
+      user.update!(score: 10)
+      expect(user.reload.base_email_eligible).to eq(true)
+    end
   end
 
   describe ".email_eligible scope" do
@@ -117,6 +137,12 @@
       end
     end
 
+    let!(:negative_score_user) do
+      create(:user, registered: true, email: "negative@example.com", score: -10).tap do |u|
+        u.notification_setting.update!(email_newsletter: true)
+      end
+    end
+
     context "when USE_BASE_EMAIL_ELIGIBLE_COLUMN is true" do
       before do
         stub_const("ENV", ENV.to_hash.merge("USE_BASE_EMAIL_ELIGIBLE_COLUMN" => "true"))
@@ -126,9 +152,11 @@
         # We manually update one parameter without firing callbacks to truly test the column itself
         eligible_user.update_column(:base_email_eligible, true)
         ineligible_user.update_column(:base_email_eligible, false)
+        negative_score_user.update_column(:base_email_eligible, false)
 
         expect(User.email_eligible).to include(eligible_user)
         expect(User.email_eligible).not_to include(ineligible_user)
+        expect(User.email_eligible).not_to include(negative_score_user)
       end
     end
 
@@ -140,6 +168,7 @@
       it "uses the legacy associations" do
         expect(User.email_eligible).to include(eligible_user)
         expect(User.email_eligible).not_to include(ineligible_user)
+        expect(User.email_eligible).not_to include(negative_score_user)
       end
     end
   end

spec/models/user_spec.rb

@@ -736,6 +736,17 @@ def provider_username(service_name)
       user.calculate_score
       expect(user.score).to eq(-470)
     end
+
+    it "syncs base_email_eligible! after calculating score" do
+      user.update!(email: "test@example.com", registered: true)
+      user.notification_setting.update!(email_newsletter: true)
+      expect(user.base_email_eligible).to eq(true)
+
+      user.add_role(:spam)
+      user.calculate_score
+      
+      expect(user.base_email_eligible).to eq(false)
+    end
   end
 
   describe "cache counts" do