Declouple Controller from MongoDB

[marcosvidolin]

Hi,

We have a MongoDB dependency in the controller. You can see here: https://github.com/amitshekhariitbhu/go-backend-clean-architecture/blob/main/api/controller/task_controller.go#L8
Maybe we should consider move the code bellow to other layer:

task.ID = primitive.NewObjectID()
task.UserID, err = primitive.ObjectIDFromHex(userID)

What's your thoughts?

[amitshekhariitbhu]

Hi @marcosvidolin

Your point is valid. A few more developers also suggested making this change. I shall do it.

Thanks

[ZeusMode]

Hi @marcosvidolin

I understood your suggestion but makes me wonder how can we properly handle errors like this to not be generic InternalServerError?

Sorry for the late response here, I just found this project

[marcosvidolin]

I would recommend moving this code to the MongoDB repository and also suggest creating a custom error in the following manner:

task, err := primitive.ObjectIDFromHex(userID)
if err != nil {
    return nil, ErrMyCustonIDGeneration("error message") // change the error name ;)
}