Skip to content

Commit cf88f31

Browse files
committed
chore: align Build-Android APK/AAB versionCode and naming to android11+
1 parent 2c791fa commit cf88f31

3 files changed

Lines changed: 9 additions & 12 deletions

File tree

.github/workflows/deploy.yml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -859,19 +859,21 @@ jobs:
859859
QT_ANDROID_KEYSTORE_STORE_PASS: ${{ secrets.ANDROID_RELEASE_KEYSTORE_KEY_PASS }}
860860
shell: bash
861861
run: |
862-
deploy/build.sh -t android --sign --aab
862+
BASE_VERSION_CODE=$(grep -oP '(?<=set\(APP_ANDROID_VERSION_CODE )\d+' CMakeLists.txt)
863+
VERSION_CODE=$((BASE_VERSION_CODE + 2))
864+
865+
APP_ANDROID_VERSION_CODE=$VERSION_CODE deploy/build.sh -t android --sign --aab
863866
864867
VERSION=$(grep CMAKE_PROJECT_VERSION:STATIC deploy/build/CMakeCache.txt | cut -d= -f2)
865868
866-
(cd deploy/build/client/android-build && mv AmneziaVPN.apk AmneziaVPN_${VERSION}_android9+_universal.apk)
869+
(cd deploy/build/client/android-build && mv AmneziaVPN.apk AmneziaVPN_${VERSION}_android11+_universal.apk)
867870
868871
for abi in arm64-v8a armeabi-v7a x86 x86_64; do
869-
deploy/build.sh -t android --sign --abi ${abi} --build ./deploy/build/${abi}
870-
(cd deploy/build/${abi}/client/android-build && mv AmneziaVPN.apk AmneziaVPN_${VERSION}_android9+_${abi}.apk)
872+
APP_ANDROID_VERSION_CODE=$VERSION_CODE deploy/build.sh -t android --sign --abi ${abi} --build ./deploy/build/${abi}
873+
(cd deploy/build/${abi}/client/android-build && mv AmneziaVPN.apk AmneziaVPN_${VERSION}_android11+_${abi}.apk)
871874
done
872875
873-
BASE_VERSION_CODE=$(grep -oP '(?<=set\(APP_ANDROID_VERSION_CODE )\d+' CMakeLists.txt)
874-
APP_ANDROID_MIN_SDK=30 APP_ANDROID_VERSION_CODE=$((BASE_VERSION_CODE + 2)) deploy/build.sh -t android --sign --aab --build ./deploy/build/aab
876+
APP_ANDROID_MIN_SDK=30 APP_ANDROID_VERSION_CODE=$VERSION_CODE deploy/build.sh -t android --sign --aab --build ./deploy/build/aab
875877
876878
(cd deploy/build/aab/client/android-build/build/outputs/bundle/release && mv android-build-release.aab AmneziaVPN_${VERSION}_android11+.aab)
877879

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ set(RELEASE_DATE "${CURRENT_DATE}")
2929

3030
set(APP_MAJOR_VERSION ${CMAKE_PROJECT_VERSION_MAJOR}.${CMAKE_PROJECT_VERSION_MINOR}.${CMAKE_PROJECT_VERSION_PATCH})
3131
if(NOT DEFINED APP_ANDROID_VERSION_CODE)
32-
set(APP_ANDROID_VERSION_CODE 2141)
32+
set(APP_ANDROID_VERSION_CODE 2140)
3333
endif()
3434

3535
if(${CMAKE_SYSTEM_NAME} STREQUAL "Linux")

client/cmake/android.cmake

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,6 @@ set_property(TARGET ${PROJECT} APPEND PROPERTY QT_ANDROID_EXTRA_LIBS ${OPENVPN_P
5757

5858
set(APP_ANDROID_PACKAGE_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/android)
5959

60-
# Qt has no target property for android:maxSdkVersion, so when a max SDK is requested we
61-
# stage a copy of the package source dir (taken after libxray.aar and other extra libs have
62-
# been copied into it above) with a <uses-sdk> tag injected into the manifest; the Android
63-
# Gradle Plugin manifest merger combines it with the min/targetSdk it generates from
64-
# QT_ANDROID_MIN/TARGET_SDK_VERSION.
6560
if(DEFINED APP_ANDROID_MAX_SDK)
6661
set(APP_ANDROID_PACKAGE_SOURCE_DIR ${CMAKE_CURRENT_BINARY_DIR}/android-package-source)
6762
file(REMOVE_RECURSE ${APP_ANDROID_PACKAGE_SOURCE_DIR})

0 commit comments

Comments
 (0)