Skip to content

Commit db054b2

Browse files
committed
fix: trim SSH server IP and submit credentials on Enter
1 parent d702dc0 commit db054b2

2 files changed

Lines changed: 32 additions & 25 deletions

File tree

client/ui/controllers/selfhosted/installUiController.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -567,12 +567,12 @@ void InstallUiController::clearProcessedServerCredentials()
567567

568568
void InstallUiController::setProcessedServerCredentials(const QString &hostName, const QString &userName, const QString &secretData)
569569
{
570-
m_processedServerCredentials.hostName = hostName;
570+
m_processedServerCredentials.hostName = hostName.trimmed();
571571
if (m_processedServerCredentials.hostName.contains(":")) {
572572
m_processedServerCredentials.port = m_processedServerCredentials.hostName.split(":").at(1).toInt();
573573
m_processedServerCredentials.hostName = m_processedServerCredentials.hostName.split(":").at(0);
574574
}
575-
m_processedServerCredentials.userName = userName;
575+
m_processedServerCredentials.userName = userName.trimmed();
576576
m_processedServerCredentials.secretData = secretData;
577577
}
578578

client/ui/qml/Pages2/PageSetupWizardCredentials.qml

Lines changed: 30 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -65,15 +65,18 @@ PageType {
6565
headerText: title
6666
textField.echoMode: hideContent ? TextInput.Password : TextInput.Normal
6767
textField.placeholderText: placeholderContent
68-
textField.text: textField.text
6968

70-
rightButtonClickedOnEnter: true
69+
rightButtonClickedOnEnter: false
7170

7271
clickedFunc: function () {
73-
clickedHandler()
74-
buttonImageSource = textField.text !== "" ? imageSource : ""
72+
if (clickedHandler) {
73+
clickedHandler()
74+
buttonImageSource = textField.text !== "" ? imageSource : ""
75+
}
7576
}
7677

78+
textField.onAccepted: root.submit()
79+
7780
textField.onFocusChanged: {
7881
textField.text = textField.text.replace(/^\s+|\s+$/g, '')
7982
}
@@ -112,25 +115,7 @@ PageType {
112115
text: qsTr("Continue")
113116

114117
clickedFunc: function() {
115-
if (!root.isCredentialsFilled()) {
116-
return
117-
}
118-
119-
var _hostname = listView.itemAtIndex(vars.hostnameIndex).children[0].textField.text
120-
var _username = listView.itemAtIndex(vars.usernameIndex).children[0].textField.text
121-
var _secretData = listView.itemAtIndex(vars.secretDataIndex).children[0].textField.text
122-
123-
InstallController.setProcessedServerCredentials(_hostname, _username, _secretData)
124-
ServersUiController.setProcessedServerId("")
125-
126-
PageController.showBusyIndicator(true)
127-
var isConnectionOpened = InstallController.checkSshConnection()
128-
PageController.showBusyIndicator(false)
129-
if (!isConnectionOpened) {
130-
return
131-
}
132-
133-
PageController.goToPage(PageEnum.PageSetupWizardEasy)
118+
root.submit()
134119
}
135120
}
136121

@@ -168,6 +153,28 @@ PageType {
168153
}
169154
}
170155

156+
function submit() {
157+
if (!root.isCredentialsFilled()) {
158+
return
159+
}
160+
161+
var _hostname = listView.itemAtIndex(vars.hostnameIndex).children[0].textField.text
162+
var _username = listView.itemAtIndex(vars.usernameIndex).children[0].textField.text
163+
var _secretData = listView.itemAtIndex(vars.secretDataIndex).children[0].textField.text
164+
165+
InstallController.setProcessedServerCredentials(_hostname, _username, _secretData)
166+
ServersUiController.setProcessedServerId("")
167+
168+
PageController.showBusyIndicator(true)
169+
var isConnectionOpened = InstallController.checkSshConnection()
170+
PageController.showBusyIndicator(false)
171+
if (!isConnectionOpened) {
172+
return
173+
}
174+
175+
PageController.goToPage(PageEnum.PageSetupWizardEasy)
176+
}
177+
171178
function isCredentialsFilled() {
172179
var hasEmptyField = false
173180

0 commit comments

Comments
 (0)