test(integration): address review findings

- Add GitHub Deployments API tests (gracefully skips if unsupported)
- Fix smoke test assertions to reject non-2xx responses
- Fix deployment list test to use find() instead of index access
- Fix globalSetup partial-failure: clean up Vercel emulator if GitHub fails

Author: amondnet

src/__integration__/github-deployments.test.ts

@@ -0,0 +1,142 @@
+import { beforeAll, describe, expect, it } from 'vitest'
+import { createOctokitClient, TEST_OWNER, TEST_REPO } from './helpers'
+
+describe('github deployments API', () => {
+  let commitSha: string
+  let deploymentsSupported = true
+
+  beforeAll(async () => {
+    const octokit = createOctokitClient()
+
+    const { data: blob } = await octokit.rest.git.createBlob({
+      owner: TEST_OWNER,
+      repo: TEST_REPO,
+      content: 'deployment test',
+      encoding: 'utf-8',
+    })
+
+    const { data: tree } = await octokit.rest.git.createTree({
+      owner: TEST_OWNER,
+      repo: TEST_REPO,
+      tree: [{ path: 'deploy.txt', mode: '100644', type: 'blob', sha: blob.sha }],
+    })
+
+    const { data: commit } = await octokit.rest.git.createCommit({
+      owner: TEST_OWNER,
+      repo: TEST_REPO,
+      message: 'deploy commit',
+      tree: tree.sha,
+      parents: [],
+    })
+
+    commitSha = commit.sha
+
+    try {
+      await octokit.rest.repos.createDeployment({
+        owner: TEST_OWNER,
+        repo: TEST_REPO,
+        ref: commitSha,
+        auto_merge: false,
+        required_contexts: [],
+      })
+    }
+    catch {
+      deploymentsSupported = false
+    }
+  })
+
+  it('should create a deployment', async () => {
+    if (!deploymentsSupported) {
+      console.log('Skipping: GitHub Deployments API not supported by emulator')
+      return
+    }
+
+    const octokit = createOctokitClient()
+
+    const { data: deployment } = await octokit.rest.repos.createDeployment({
+      owner: TEST_OWNER,
+      repo: TEST_REPO,
+      ref: commitSha,
+      auto_merge: false,
+      required_contexts: [],
+    })
+
+    expect(deployment).toBeDefined()
+    expect('id' in deployment).toBe(true)
+  })
+
+  it('should create deployment statuses with state transitions', async () => {
+    if (!deploymentsSupported) {
+      console.log('Skipping: GitHub Deployments API not supported by emulator')
+      return
+    }
+
+    const octokit = createOctokitClient()
+
+    const { data: deployment } = await octokit.rest.repos.createDeployment({
+      owner: TEST_OWNER,
+      repo: TEST_REPO,
+      ref: commitSha,
+      auto_merge: false,
+      required_contexts: [],
+    })
+
+    if (!('id' in deployment)) {
+      throw new Error('Expected deployment to have an id')
+    }
+
+    const { data: pendingStatus } = await octokit.rest.repos.createDeploymentStatus({
+      owner: TEST_OWNER,
+      repo: TEST_REPO,
+      deployment_id: deployment.id,
+      state: 'pending',
+    })
+    expect(pendingStatus.state).toBe('pending')
+
+    const { data: successStatus } = await octokit.rest.repos.createDeploymentStatus({
+      owner: TEST_OWNER,
+      repo: TEST_REPO,
+      deployment_id: deployment.id,
+      state: 'success',
+    })
+    expect(successStatus.state).toBe('success')
+  })
+
+  it('should list deployment statuses', async () => {
+    if (!deploymentsSupported) {
+      console.log('Skipping: GitHub Deployments API not supported by emulator')
+      return
+    }
+
+    const octokit = createOctokitClient()
+
+    const { data: deployment } = await octokit.rest.repos.createDeployment({
+      owner: TEST_OWNER,
+      repo: TEST_REPO,
+      ref: commitSha,
+      auto_merge: false,
+      required_contexts: [],
+    })
+
+    if (!('id' in deployment)) {
+      throw new Error('Expected deployment to have an id')
+    }
+
+    await octokit.rest.repos.createDeploymentStatus({
+      owner: TEST_OWNER,
+      repo: TEST_REPO,
+      deployment_id: deployment.id,
+      state: 'success',
+    })
+
+    const { data: statuses } = await octokit.rest.repos.listDeploymentStatuses({
+      owner: TEST_OWNER,
+      repo: TEST_REPO,
+      deployment_id: deployment.id,
+    })
+
+    expect(statuses.length).toBeGreaterThan(0)
+    const found = statuses.find(s => s.state === 'success')
+    expect(found).toBeDefined()
+  })
+})

src/__integration__/global-setup.ts

@@ -4,9 +4,6 @@ import { resolve } from 'node:path'
 import { createEmulator } from 'emulate'
 import { parse } from 'yaml'
 
-const VERCEL_PORT = 4000
-const GITHUB_PORT = 4001
-
 let vercelEmulator: Emulator
 let githubEmulator: Emulator
 
@@ -21,15 +18,21 @@ export async function setup(): Promise<void> {
 
   vercelEmulator = await createEmulator({
     service: 'vercel',
-    port: VERCEL_PORT,
+    port: 4000,
     seed,
   })
 
-  githubEmulator = await createEmulator({
-    service: 'github',
-    port: GITHUB_PORT,
-    seed,
-  })
+  try {
+    githubEmulator = await createEmulator({
+      service: 'github',
+      port: 4001,
+      seed,
+    })
+  }
+  catch (error) {
+    await vercelEmulator.close()
+    throw error
+  }
 
   process.env.EMULATE_VERCEL_URL = vercelEmulator.url
   process.env.EMULATE_GITHUB_URL = githubEmulator.url

src/__integration__/smoke.test.ts

@@ -15,11 +15,13 @@ describe('emulate.dev smoke test', () => {
     const res = await fetch(`${process.env.EMULATE_VERCEL_URL}/v2/user`, {
       headers: { Authorization: 'Bearer test-token' },
     })
-    expect(res.status).toBeLessThan(500)
+    expect(res.ok).toBe(true)
   })
 
   it('should reach GitHub emulator', async () => {
-    const res = await fetch(`${process.env.EMULATE_GITHUB_URL}/user`)
-    expect(res.status).toBeLessThan(500)
+    const res = await fetch(`${process.env.EMULATE_GITHUB_URL}/user`, {
+      headers: { Authorization: 'Bearer test-token' },
+    })
+    expect(res.ok).toBe(true)
   })
 })

src/__integration__/vercel-deployments.test.ts

@@ -62,8 +62,8 @@ describe('vercel deployments API', () => {
     expect(data.deployments).toBeDefined()
     expect(data.deployments.length).toBeGreaterThan(0)
 
-    const deployment = data.deployments[0]
-    expect(deployment.name).toBe(TEST_PROJECT)
+    const deployment = data.deployments.find((d: { name: string }) => d.name === TEST_PROJECT)
+    expect(deployment).toBeDefined()
     expect(deployment.url).toBeDefined()
   })
 })