Skip to content

Commit 9146486

Browse files
committed
fix: require both vercel-org-id and vercel-project-id for deployment
Vercel CLI requires both VERCEL_ORG_ID and VERCEL_PROJECT_ID to be set together. Previously, setting only vercel-project-id without vercel-org-id caused a CLI error. - skip setting VERCEL_PROJECT_ID when vercel-org-id is missing and warn - also remove VERCEL_PROJECT_ID in the personal account retry path - add missing vercel-org-id to example-static, example-angular, and deploy workflows
1 parent 6011ab6 commit 9146486

5 files changed

Lines changed: 31 additions & 6 deletions

File tree

.github/workflows/deploy.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ jobs:
1616
github-token: ${{ secrets.GITHUB_TOKEN }}
1717
vercel-token: ${{ secrets.VERCEL_TOKEN }}
1818
github-comment: false
19+
vercel-org-id: ${{ secrets.VERCEL_ORG_ID }}
1920
vercel-project-id: ${{ secrets.VERCEL_PROJECT_ID_STATIC }}
2021
- name: preview-url
2122
run: |

.github/workflows/example-angular.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ jobs:
3434
with:
3535
github-token: ${{ secrets.GITHUB_TOKEN }}
3636
vercel-token: ${{ secrets.VERCEL_TOKEN }}
37+
vercel-org-id: ${{ secrets.VERCEL_ORG_ID }}
3738
vercel-project-id: ${{ secrets.VERCEL_PROJECT_ID_ANGULAR }}
3839
working-directory: example/angular/dist/angular
3940
alias-domains: |
@@ -45,6 +46,7 @@ jobs:
4546
with:
4647
github-token: ${{ secrets.GITHUB_TOKEN }}
4748
vercel-token: ${{ secrets.VERCEL_TOKEN }}
49+
vercel-org-id: ${{ secrets.VERCEL_ORG_ID }}
4850
vercel-project-id: ${{ secrets.VERCEL_PROJECT_ID_ANGULAR }}
4951
working-directory: example/angular/dist/angular
5052
vercel-args: '--prod '

.github/workflows/example-static.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ jobs:
1717
with:
1818
github-token: ${{ secrets.GITHUB_TOKEN }}
1919
vercel-token: ${{ secrets.VERCEL_TOKEN }}
20+
vercel-org-id: ${{ secrets.VERCEL_ORG_ID }}
2021
vercel-project-id: ${{ secrets.VERCEL_PROJECT_ID_STATIC }}
2122
working-directory: example/static
2223
alias-domains: |
@@ -39,6 +40,7 @@ jobs:
3940
with:
4041
github-token: ${{ secrets.GITHUB_TOKEN }}
4142
vercel-token: ${{ secrets.VERCEL_TOKEN }}
43+
vercel-org-id: ${{ secrets.VERCEL_ORG_ID }}
4244
vercel-project-id: ${{ secrets.VERCEL_PROJECT_ID_STATIC }}
4345
vercel-args: ${{ steps.prod_or_not.outputs.vercel-args }}
4446
working-directory: example/static

dist/index.js

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59685,14 +59685,23 @@ if (githubToken) {
5968559685
async function setEnv() {
5968659686
core.info('set environment for vercel cli')
5968759687
core.exportVariable('VERCEL_TELEMETRY_DISABLED', '1')
59688-
if (vercelOrgId) {
59688+
if (vercelOrgId && vercelProjectId) {
5968959689
core.info('set env variable : VERCEL_ORG_ID')
5969059690
core.exportVariable('VERCEL_ORG_ID', vercelOrgId)
59691-
}
59692-
if (vercelProjectId) {
5969359691
core.info('set env variable : VERCEL_PROJECT_ID')
5969459692
core.exportVariable('VERCEL_PROJECT_ID', vercelProjectId)
5969559693
}
59694+
else if (vercelOrgId) {
59695+
core.info('set env variable : VERCEL_ORG_ID')
59696+
core.exportVariable('VERCEL_ORG_ID', vercelOrgId)
59697+
}
59698+
else if (vercelProjectId) {
59699+
core.warning(
59700+
'vercel-project-id was provided without vercel-org-id. '
59701+
+ 'Vercel CLI v41+ requires both to be set together. '
59702+
+ 'Skipping VERCEL_PROJECT_ID to avoid deployment failure.',
59703+
)
59704+
}
5969659705
}
5969759706

5969859707
function addVercelMetadata(key, value, providedArgs) {
@@ -59801,6 +59810,7 @@ async function vercelDeploy(ref, commit, sha, commitOrg, commitRepo) {
5980159810
+ 'Retrying without VERCEL_ORG_ID (VERCEL_PROJECT_ID is still set).',
5980259811
)
5980359812
delete process.env.VERCEL_ORG_ID
59813+
delete process.env.VERCEL_PROJECT_ID
5980459814

5980559815
const originalOutput = myOutput
5980659816
const originalError = myError

index.js

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,14 +100,23 @@ if (githubToken) {
100100
async function setEnv() {
101101
core.info('set environment for vercel cli')
102102
core.exportVariable('VERCEL_TELEMETRY_DISABLED', '1')
103-
if (vercelOrgId) {
103+
if (vercelOrgId && vercelProjectId) {
104104
core.info('set env variable : VERCEL_ORG_ID')
105105
core.exportVariable('VERCEL_ORG_ID', vercelOrgId)
106-
}
107-
if (vercelProjectId) {
108106
core.info('set env variable : VERCEL_PROJECT_ID')
109107
core.exportVariable('VERCEL_PROJECT_ID', vercelProjectId)
110108
}
109+
else if (vercelOrgId) {
110+
core.info('set env variable : VERCEL_ORG_ID')
111+
core.exportVariable('VERCEL_ORG_ID', vercelOrgId)
112+
}
113+
else if (vercelProjectId) {
114+
core.warning(
115+
'vercel-project-id was provided without vercel-org-id. '
116+
+ 'Vercel CLI v41+ requires both to be set together. '
117+
+ 'Skipping VERCEL_PROJECT_ID to avoid deployment failure.',
118+
)
119+
}
111120
}
112121

113122
function addVercelMetadata(key, value, providedArgs) {
@@ -216,6 +225,7 @@ async function vercelDeploy(ref, commit, sha, commitOrg, commitRepo) {
216225
+ 'Retrying without VERCEL_ORG_ID (VERCEL_PROJECT_ID is still set).',
217226
)
218227
delete process.env.VERCEL_ORG_ID
228+
delete process.env.VERCEL_PROJECT_ID
219229

220230
const originalOutput = myOutput
221231
const originalError = myError

0 commit comments

Comments
 (0)