Commit 0ba8129
ci: typecheck only what the plugin actually imports
The release workflow failed on `tsc --noEmit`: the plugin's tsconfig
globbed `../engine-js/src/**/*.ts`, which sweeps in the engine's *Node*
adapters (`src/pdf.ts`, `src/vlm.ts`). Those import `@napi-rs/canvas` and
`pdfjs-dist/legacy` — dependencies of the engine-js package, which CI
never installs because it runs `npm ci` in plugin/ alone. It passed
locally only because engine-js/node_modules happened to be populated from
running that package's tests, so the check was quietly machine-dependent.
Listing just the plugin's own sources is both the fix and the more
accurate description: tsc follows imports, so engine core/ and browser/
are still fully checked — verified by planting a type error in
browser/device.ts and watching it fail — while the Node adapters, which
the plugin never imports, are left to engine-js's own tsconfig.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent 8549943 commit 0ba8129
1 file changed
Lines changed: 9 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
18 | 26 | | |
0 commit comments