feat: Github Codespaces Plugin #328
Conversation
|
@pyxelpioneer could you please address the CI failures? |
|
@overbit fixed ci failing |
There was a problem hiding this comment.
@pyxelpioneer Can you update the README to provide some more context as well as steps on how to startup the dev container after app is generated.
plugins/devcontainer-github-codespaces/src/static/admin.docker-compose.yml
Outdated
Show resolved
Hide resolved
@pyxelpioneer What I meant was adding steps on how to run the dev container after the service is made. |
Oh sorry, I forgot to add that, but now I have added |
|
@overbit rest everything is fine by me. Could you have a look once too? |
There was a problem hiding this comment.
Nice work @pyxelpioneer !
I added one comment about an empty file in the tests directory, but other than that it LGTM.
…generate admin ui This commit lets the admin ui overwrite the devcontainer config during the `afterCreateAdminUI` event and not in `afterCreateServer` event. This ensures that if the user doesnt opt in to generate the admin ui, then the `afterCreateAdminUI` event is never trigged, so admin ui config doesn't get generated (even if user specifies `includeAdminUI: true` in settings), thus preventing generating of slate docker compose file
|
I am still working, just busy with some other work at the moment. I will upload the video by tomorrow |
|
Okay so i was busy with intra-state shifting but now I have settled and I will send the video today |
|
@pyxelpioneer any updates on this ? |
I was actually making the video, and saw that I was being hit with a CORS error on Admin UI (even though the server and the client are both accessable from web), which I hadn't noticed because I thought it would work out of the box anyways. I don't really know the issue, and I am trying to fix that. |
|
Just updating, I was able to fix the CORS issue in the build generated by app.amplication.com, but there are still some bugs with the local build (weird). WIll not take too long to fix it up. |
|
Hey @overbit @Shurtu-gal @levivannoort , sorry for the extreme delay due to shifting, my codespace limit gettting full etc. Thanks for not closing this PR! Here is the video showing the output based on the rework of the plugin. dance-2024-04-07_22.online-video-cutter.com.mp4 |
Hey @overbit ? |
|
Well done @pyxelpioneer! We are reviewing it. |
|
@Shurtu-gal are you happy to approve this PR too? I see that all your comments have been addressed |
Thanks 😍 |
|
Great Work @pyxelpioneer!!! |
Thanks 😍 |
Fixes: amplication/amplication#7012
PR Details
Adds the plugin as per defined in issue #7012
PR Checklist
npm builddoesn't throw any errornpm testdoesn't throw any errorIMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.